Use Iterable for PartiQLValue collections rather than Sequence #1305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conformance comparison report
Number passing in both: 5384 Number failing in both: 434 Number passing in Base (6ab6f27) but now fail: 0 Number failing in Base (6ab6f27) but now pass: 0 |
johnedquinn
reviewed
Dec 13, 2023
partiql-types/src/main/kotlin/org/partiql/value/PartiQLValue.kt
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1305 +/- ##
============================================
- Coverage 72.21% 72.20% -0.02%
Complexity 2100 2100
============================================
Files 222 222
Lines 16021 16024 +3
Branches 2892 2895 +3
============================================
Hits 11570 11570
- Misses 3635 3638 +3
Partials 816 816
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
johnedquinn
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issues
N/A
Description
A sequence gets exhausted after consumed once which does not make it a good option for the default backing field. This PR replaces the collection data structure with the Iterable interface. This allows requesting a new iterator which gives freedom in the implementation of the backing structure. You can use sequences or lazily-generated iterators, but importantly this is not the default.
Other Information
Updated Unreleased Section in CHANGELOG: [YES/NO]
Yes
Any backward-incompatible changes? [YES/NO]
No. PartiQLValue is considered experimental.
Any new external dependencies? [YES/NO]
No
Do your changes comply with the Contributing Guidelines
and Code Style Guidelines? [YES/NO]
Yes
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.