Adds support for DISTINCT in Eval #1292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conformance comparison report
Number passing in both: 5384 Number failing in both: 434 Number passing in Base (16f9cca) but now fail: 0 Number failing in Base (16f9cca) but now pass: 0 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## partiql-eval #1292 +/- ##
===============================================
Coverage ? 49.26%
Complexity ? 1046
===============================================
Files ? 166
Lines ? 13396
Branches ? 2504
===============================================
Hits ? 6600
Misses ? 6139
Partials ? 657
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
johnedquinn
force-pushed
the
add-distinct
branch
3 times, most recently
from
9ea3e31 to
a609f7f
Compare
johnedquinn
force-pushed
the
add-distinct
branch
from
a609f7f to
ab71411
Compare
rchowell
approved these changes
Dec 20, 2023
| structValue( | ||
| "a" to int32Value(1), | ||
| "b" to int32Value(2) | ||
| SuccessTestCase( |
There was a problem hiding this comment.
Nice. Thanks. Would be nice to have these in files somewhere like typer tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issues
Description
Other Information
and Code Style Guidelines? YES
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.