-
Notifications
You must be signed in to change notification settings - Fork 63
Add partiql-planner Maven publishing plugin v0.11.1 #1215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -25,6 +26,17 @@ dependencies { | |||
implementation(Deps.kotlinReflect) | |||
} | |||
|
|||
// Disabled for partiql-plan project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New in this PR: disable expclit api mode for the generated code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised v0.10.1 didn't have this. Do you know why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAICT v0.10.0 (and v0.10.1 since v0.10.1 is based off v0.10.0) didn't have the explicit API change yet. Explicit API mode seems to have been enabled for the v0.11.0 release: #1081
Conformance comparison report
Number passing in both: 4271 Number failing in both: 113 Number passing in Base (748e8eb) but now fail: 0 Number failing in Base (748e8eb) but now pass: 0 |
CHANGELOG.md
Outdated
@@ -35,6 +35,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|||
### Security | |||
|
|||
## [0.11.1] - 2023-09-19 | |||
|
|||
### Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment regarding fixes for v0.10.1
PR
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## v0.11.1 #1215 +/- ##
==========================================
Coverage 74.87% 74.87%
Complexity 2448 2448
==========================================
Files 255 255
Lines 18940 18940
Branches 3454 3454
==========================================
Hits 14181 14181
Misses 3691 3691
Partials 1068 1068
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
Adds a Maven publishing step to
partiql-planner
and changes partiql-lang-kotlin's dependency onpartiql-planner
to beapi
.Other Information
Updated Unreleased Section in CHANGELOG: Yes
Any backward-incompatible changes? No
Any new external dependencies? No
Do your changes comply with the Contributing Guidelines
and Code Style Guidelines? Yes
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.