Skip to content

Add partiql-planner Maven publishing plugin v0.11.1 #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 20, 2023
Merged

Conversation

alancai98
Copy link
Member

Description

Adds a Maven publishing step to partiql-planner and changes partiql-lang-kotlin's dependency on partiql-planner to be api.

Other Information

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alancai98 alancai98 self-assigned this Sep 19, 2023
@@ -25,6 +26,17 @@ dependencies {
implementation(Deps.kotlinReflect)
}

// Disabled for partiql-plan project.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New in this PR: disable expclit api mode for the generated code

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised v0.10.1 didn't have this. Do you know why?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT v0.10.0 (and v0.10.1 since v0.10.1 is based off v0.10.0) didn't have the explicit API change yet. Explicit API mode seems to have been enabled for the v0.11.0 release: #1081

@github-actions
Copy link

github-actions bot commented Sep 20, 2023

Conformance comparison report

Base (748e8eb) 2047050 +/-
% Passing 97.42% 97.42% 0.00%
✅ Passing 4271 4271 0
❌ Failing 113 113 0
🔶 Ignored 0 0 0
Total Tests 4384 4384 0

Number passing in both: 4271

Number failing in both: 113

Number passing in Base (748e8eb) but now fail: 0

Number failing in Base (748e8eb) but now pass: 0

CHANGELOG.md Outdated
@@ -35,6 +35,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Security

## [0.11.1] - 2023-09-19

### Added
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment regarding fixes for v0.10.1 PR

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (748e8eb) 74.87% compared to head (8ea3c41) 74.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             v0.11.1    #1215   +/-   ##
==========================================
  Coverage      74.87%   74.87%           
  Complexity      2448     2448           
==========================================
  Files            255      255           
  Lines          18940    18940           
  Branches        3454     3454           
==========================================
  Hits           14181    14181           
  Misses          3691     3691           
  Partials        1068     1068           
Flag Coverage Δ
CLI 14.53% <ø> (ø)
EXAMPLES 80.44% <ø> (ø)
LANG 79.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alancai98 alancai98 merged commit 68023ac into v0.11.1 Sep 20, 2023
@alancai98 alancai98 deleted the prepare-v0.11.1 branch September 20, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants