Skip to content

Adds asAlias property to INSERT AST node #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

johnedquinn
Copy link
Member

Relevant Issues

Description

  • Breaking: Adds asAlias nullable property to the insert AST node.
  • Modifies tests corresponding to the change
  • This PR does NOT add the alias to the DML Conflict Action -- as the current planner does NOT support any action besides EXCLUDED -- which does not reference the alias. This will need to be addressed once we extend support to the conflict action value to include SET/VALUE according to the RFC.

Other Information

  • Updated Unreleased Section in CHANGELOG: YES
  • Any backward-incompatible changes? YES
    • Yes, the public AST node insert now contains another property called asAlias
  • Any new external dependencies? NO

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

Conformance comparison report

Base (7b57c5f) 5b03dc4 +/-
% Passing 97.42% 97.42% 0.00%
✅ Passing 4271 4271 0
❌ Failing 113 113 0
🔶 Ignored 0 0 0
Total Tests 4384 4384 0

Number passing in both: 4271

Number failing in both: 113

Number passing in Base (7b57c5f) but now fail: 0

Number failing in Base (7b57c5f) but now pass: 0

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2023

Codecov Report

Patch coverage: 70.00% and project coverage change: -0.02 ⚠️

Comparison is base (7b57c5f) 74.88% compared to head (8a9724b) 74.86%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1055      +/-   ##
============================================
- Coverage     74.88%   74.86%   -0.02%     
  Complexity     2315     2315              
============================================
  Files           248      248              
  Lines         18463    18462       -1     
  Branches       3351     3351              
============================================
- Hits          13826    13822       -4     
  Misses         3627     3627              
- Partials       1010     1013       +3     
Flag Coverage Δ
CLI 13.93% <ø> (ø)
EXAMPLES 80.44% <ø> (ø)
LANG 79.64% <70.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/kotlin/org/partiql/lang/syntax/PartiQLVisitor.kt 91.51% <70.00%> (-0.26%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@johnedquinn
Copy link
Member Author

Closing, as #1061 also resolves this issue.

@johnedquinn johnedquinn closed this May 2, 2023
@johnedquinn johnedquinn deleted the insert-alias branch May 2, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

INSERT with alias loses original table name which is replaced with the alias
2 participants