Skip to content

PartiQLValueTextWriter currently does not implement printing datetime values #1491

Closed
@alancai98

Description

@alancai98

Description

PartiQLValueTextWriter does not print datetime values. Currently it does not implement the writer for datetime values, so attempting to print out a datetime value will result in an IllegalArgumentException.

This is also pointed out in the tests:

.

To Reproduce

Steps to reproduce the behavior:

  1. Call PartiQLValueTextWriter's append, which calls the ToString visitor with a datetime PartiQLValue
  2. Get an IllegalArgumentException -- Caused by: java.lang.IllegalArgumentException: Cannot write value of type DATE

Expected Behavior

  • Expect PartiQLValueTextWriter to print out datetime values

Additional Context

  • Java version: 11
  • PartiQL version: tested w/ 0.14.6-SNAPSHOT and 0.14.5

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions