Skip to content

[Quectel] Account for "eMTC" type while obtaining signal values #2589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

keeramis
Copy link
Contributor

@keeramis keeramis commented Nov 29, 2022

Problem

Signal values on certain Cat-M1 radios are invalid. Example: BG95-M1 / TrackerM

Solution

Account for eMTC type/sysmode while collecting signal values from QCSQ. Added minor correction around NBIoT wording.

Steps to Test

Run test-runner for slo/connect_time tests on trackerM or any module with BG95-M1 radio
Results should have valid signal values collected as below.

stats:
{ cold:
   { cloud_connect: [ 15233, 14841, 17527, 17399, 15229, 14993, 15228, 18301 ],
     network_connect: [ 5670, 5550, 5514, 5610, 5535, 5533, 5814, 5614 ],
     cloud_full_handshake: [ 8373, 8109, 10831, 10599, 8504, 8274, 8231, 11497 ],
     signal:
      { rat:
         [ 'LTE M1', 'LTE M1', 'LTE M1', 'LTE M1', 'LTE M1', 'LTE M1', 'LTE M1', 'LTE M1' ],
        sig_perc: [ 67.5, 72.5, 72.5, 80, 80, 65, 75, 75 ],
        qual_perc: [ 100, 87.5, 100, 87.5, 100, 87.5, 100, 87.5 ],
        sig: [ -88, -86, -86, -82, -82, -89, -85, -85 ],
        qual: [ -6, -7, -6, -7, -6, -7, -6, -7 ] } },
  warm:
   { cloud_connect: [ 4521, 4617, 10020, 4642, 4441, 4580, 4514, 4673 ],
     network_connect: [ 1195, 1195, 1195, 1197, 1195, 1195, 1195, 1195 ],
     cloud_session_resume: [ 2136, 2239, 7634, 2255, 2055, 2195, 2129, 2288 ],
     signal:
      { rat:
         [ 'LTE M1', 'LTE M1', 'LTE M1', 'LTE M1', 'LTE M1', 'LTE M1', 'LTE M1', 'LTE M1' ],
        sig_perc: [ 76.7, 72.5, 75, 75, 78.3, 75, 72.5, 75 ],
        qual_perc: [ 87.5, 87.5, 87.5, 87.5, 75, 87.5, 75, 87.5 ],
        sig: [ -84, -86, -85, -85, -83, -85, -86, -85 ],
        qual: [ -7, -7, -7, -7, -8, -7, -8, -7 ] } } }
cloud_connect_time_from_cold_boot: 17399
cloud_connect_time_from_warm_boot: 4642
        ✓ publish_and_validate_stats
    Resetting device


  17 passing (6m)


References

SC-110518


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

radioType == DEV_QUECTEL_BG95_M1 || radioType == DEV_QUECTEL_EG91_NAX ||
radioType == DEV_QUECTEL_BG77 || radioType == DEV_QUECTEL_BG95_MF);
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unclear which quectel radio types need this delay so adding 'em all just in case.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can check the vendor bit instead then. PLATFORM_NCP_MANUFACTURER(radioType) == PLATFORM_NCP_MANUFACTURER_QUECTEL

@@ -695,7 +695,8 @@ int QuectelNcpClient::getSignalQuality(CellularSignalQuality* qual) {
{"TDSCDMA", CellularAccessTechnology::UTRAN},
{"LTE", CellularAccessTechnology::LTE},
{"CAT-M1", CellularAccessTechnology::LTE_CAT_M1},
{"CAT-NB1", CellularAccessTechnology::LTE_NB_IOT}
{"eMTC", CellularAccessTechnology::LTE_CAT_M1},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd leave CAT-NB1 just in case as well. I think it does report it like that on some of the modems.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avtolstoy From BG95 manual, it is "NBIoT". I will leave both entries for LTE_NB_IOT if that sounds reasonable.
Screen Shot 2022-11-29 at 1 17 36 AM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BG95-M1 does not support Cat-NB1/NB2, but some BG95-M6 and MF do. That said we disable scanning on Cat-NB1/NB2 on those modems so you likely won't see NBIoT pop up. Ok to leave it in the list though.

radioType == DEV_QUECTEL_BG95_M1 || radioType == DEV_QUECTEL_EG91_NAX ||
radioType == DEV_QUECTEL_BG77 || radioType == DEV_QUECTEL_BG95_MF);
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can check the vendor bit instead then. PLATFORM_NCP_MANUFACTURER(radioType) == PLATFORM_NCP_MANUFACTURER_QUECTEL

@keeramis keeramis force-pushed the fix/eMTC_signal_values branch from cb870fd to d29e1e6 Compare November 29, 2022 16:40
@@ -695,7 +695,8 @@ int QuectelNcpClient::getSignalQuality(CellularSignalQuality* qual) {
{"TDSCDMA", CellularAccessTechnology::UTRAN},
{"LTE", CellularAccessTechnology::LTE},
{"CAT-M1", CellularAccessTechnology::LTE_CAT_M1},
{"CAT-NB1", CellularAccessTechnology::LTE_NB_IOT}
{"eMTC", CellularAccessTechnology::LTE_CAT_M1},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BG95-M1 does not support Cat-NB1/NB2, but some BG95-M6 and MF do. That said we disable scanning on Cat-NB1/NB2 on those modems so you likely won't see NBIoT pop up. Ok to leave it in the list though.

@keeramis keeramis force-pushed the fix/eMTC_signal_values branch from d29e1e6 to 74f540f Compare November 29, 2022 17:09
@keeramis keeramis modified the milestones: 5.2.0, 4.0.2 Nov 29, 2022
@keeramis keeramis force-pushed the fix/eMTC_signal_values branch from 74f540f to 0ef7764 Compare November 29, 2022 17:59
@keeramis keeramis merged commit 50e24de into develop Nov 29, 2022
@keeramis keeramis deleted the fix/eMTC_signal_values branch November 29, 2022 21:47
@keeramis keeramis restored the fix/eMTC_signal_values branch December 5, 2022 15:35
@scott-brust scott-brust modified the milestones: 4.0.2, 5.2.0 Dec 16, 2022
technobly pushed a commit that referenced this pull request May 24, 2023
[Quectel] Account for "eMTC" type while obtaining signal values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants