-
Notifications
You must be signed in to change notification settings - Fork 520
[Quectel] Account for "eMTC" type while obtaining signal values #2589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
radioType == DEV_QUECTEL_BG95_M1 || radioType == DEV_QUECTEL_EG91_NAX || | ||
radioType == DEV_QUECTEL_BG77 || radioType == DEV_QUECTEL_BG95_MF); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unclear which quectel radio types need this delay so adding 'em all just in case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can check the vendor bit instead then. PLATFORM_NCP_MANUFACTURER(radioType) == PLATFORM_NCP_MANUFACTURER_QUECTEL
@@ -695,7 +695,8 @@ int QuectelNcpClient::getSignalQuality(CellularSignalQuality* qual) { | |||
{"TDSCDMA", CellularAccessTechnology::UTRAN}, | |||
{"LTE", CellularAccessTechnology::LTE}, | |||
{"CAT-M1", CellularAccessTechnology::LTE_CAT_M1}, | |||
{"CAT-NB1", CellularAccessTechnology::LTE_NB_IOT} | |||
{"eMTC", CellularAccessTechnology::LTE_CAT_M1}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd leave CAT-NB1 just in case as well. I think it does report it like that on some of the modems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@avtolstoy From BG95 manual, it is "NBIoT". I will leave both entries for LTE_NB_IOT
if that sounds reasonable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BG95-M1 does not support Cat-NB1/NB2, but some BG95-M6 and MF do. That said we disable scanning on Cat-NB1/NB2 on those modems so you likely won't see NBIoT pop up. Ok to leave it in the list though.
radioType == DEV_QUECTEL_BG95_M1 || radioType == DEV_QUECTEL_EG91_NAX || | ||
radioType == DEV_QUECTEL_BG77 || radioType == DEV_QUECTEL_BG95_MF); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can check the vendor bit instead then. PLATFORM_NCP_MANUFACTURER(radioType) == PLATFORM_NCP_MANUFACTURER_QUECTEL
cb870fd
to
d29e1e6
Compare
@@ -695,7 +695,8 @@ int QuectelNcpClient::getSignalQuality(CellularSignalQuality* qual) { | |||
{"TDSCDMA", CellularAccessTechnology::UTRAN}, | |||
{"LTE", CellularAccessTechnology::LTE}, | |||
{"CAT-M1", CellularAccessTechnology::LTE_CAT_M1}, | |||
{"CAT-NB1", CellularAccessTechnology::LTE_NB_IOT} | |||
{"eMTC", CellularAccessTechnology::LTE_CAT_M1}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BG95-M1 does not support Cat-NB1/NB2, but some BG95-M6 and MF do. That said we disable scanning on Cat-NB1/NB2 on those modems so you likely won't see NBIoT pop up. Ok to leave it in the list though.
d29e1e6
to
74f540f
Compare
74f540f
to
0ef7764
Compare
[Quectel] Account for "eMTC" type while obtaining signal values
Problem
Signal values on certain Cat-M1 radios are invalid. Example: BG95-M1 / TrackerM
Solution
Account for
eMTC
type/sysmode while collecting signal values from QCSQ. Added minor correction around NBIoT wording.Steps to Test
Run test-runner for
slo/connect_time
tests on trackerM or any module with BG95-M1 radioResults should have valid signal values collected as below.
References
SC-110518
Completeness