Updates for Tracker M proto 3 #2580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avtolstoy
approved these changes
Nov 15, 2022
| iocon |= 1u << 6; | ||
| #endif | ||
| #if HAL_PLATFORM_MCP23S17_OPEN_DRAIN_INT | ||
| iocon |= 1u << 2; |
There was a problem hiding this comment.
Nit: magic numbers. We have plenty of those here, but if we can define self-describing constants for these would be great.
There was a problem hiding this comment.
I generally agree, but in a case where the descriptive flag is right next to the magic number that's used once, it's not adding much. 🤷♂️
jmwilson
force-pushed
the
feature/sc-112085
branch
from
291f777 to
b06b1b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Tracker M proto 3 has the wakeup pin to or the PMIC and IO expander interrupts so either can wake it from deep sleep. This means the IO expander should set its interrupt output as open drain.
In proto 2, the cell reset line was disconnected via a DNP jumper. In proto 3, is connected to the cell modem reset (which is internally connected to modem power). Since the cell modem pins are level-shifted from the MCU pins via open drain MOSFETs it is ok to have the MCU pins driven separately and will mean the pinmap doesn't have to change for an EG91 variant.
Completeness