Skip to content

[p2] WiFi bugfixes #2562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2022
Merged

[p2] WiFi bugfixes #2562

merged 1 commit into from
Oct 24, 2022

Conversation

avtolstoy
Copy link
Member

Description

  • Adds support for WPA2/WPA3 mixed APs
  • Fixes race condition in RealtekNcpClient::getNetworkInfo() when calling into Realtek SDK without a lock with network threads potentially doing the same. This occasionally causes a crash.

Steps to Test

N/A

Example App

N/A

References

N/A

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@avtolstoy avtolstoy added this to the 5.2.0 milestone Oct 23, 2022
@avtolstoy avtolstoy merged commit d044cfb into develop Oct 24, 2022
@avtolstoy avtolstoy deleted the fix/p2-wpa3-wpa2-mixed-getnetworkinfo-race branch October 24, 2022 16:14
@scott-brust scott-brust mentioned this pull request Dec 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuGuohui XuGuohui XuGuohui approved these changes

@mrlambchop mrlambchop Awaiting requested review from mrlambchop

Assignees
No one assigned
Labels
5.x 5.x-only bug
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@avtolstoy @XuGuohui