Skip to content

refactor: Upgrade @apollo/server from 4.12.0 to 4.12.1 #9791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
],
"license": "Apache-2.0",
"dependencies": {
"@apollo/server": "4.12.0",
"@apollo/server": "4.12.1",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Approve patch bump of @apollo/server to 4.12.1

This is a safe patch upgrade that only updates internal dependencies. Confirm that 4.12.1 exists, update your lockfile, and run your CI/test suite to catch any regressions.

Run:


🏁 Script executed:

#!/bin/bash
# Verify the published version and update lockfile
npm view @apollo/[email protected] version

# Install updated deps and run tests
npm install
npm test

# Audit for vulnerabilities
npm audit

Length of output: 9095


Tests are failing after bump – missing lsb_release utility

The upgrade to @apollo/[email protected] is a safe patch bump (version exists), but your test suite errors out with:

Error: spawn lsb_release ENOENT

This indicates that mongodb-runner requires the OS lsb_release command. Please address the following before merging:

  • Ensure lsb_release is installed in your local/CI environment (e.g. apt-get install lsb-release on Debian/Ubuntu).
  • Re-run npm install and commit the updated lockfile (package-lock.json or yarn.lock).
  • Re-run npm test to confirm all tests pass.
  • Run npm audit and address any critical vulnerabilities (consider npm audit fix or npm audit fix --force for breaking changes).
🤖 Prompt for AI Agents
In package.json at line 23, after upgrading @apollo/server to version 4.12.1,
the test suite fails due to a missing OS utility 'lsb_release'. To fix this,
ensure the 'lsb_release' command is installed in your local and CI environments
(e.g., run 'apt-get install lsb-release' on Debian/Ubuntu). Then, run 'npm
install' to update dependencies and commit the updated lockfile. Finally, rerun
'npm test' to verify tests pass and run 'npm audit' to check for
vulnerabilities, fixing any critical issues as needed.

"@babel/eslint-parser": "7.27.1",
"@graphql-tools/merge": "9.0.24",
"@graphql-tools/schema": "10.0.23",
Expand Down
Loading