feat: add namespace_separator option for RPC methods #1544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
approved these changes
Apr 4, 2025
|
Had a few errors with the tests, @niklasad1. But they are resolved now. Would love to hear your thoughts. |
All right, looks good to me |
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
tests/tests/proc_macros.rs:323
- Consider adding test coverage for the scenario where
namespace_separatoris not provided, ensuring that the default '_' behavior is correctly applied.
assert_eq!(&res, "Called with: 1, test");
Thanks! I'm excited to see it get merged. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @niklasad1 & @tomaka! 👋
I just opened this issue (#1543) after noticing that
jsonrpseedoesn’t currently support namespace separators and instead defaults to using underscores.To address this, I’ve submitted a PR that introduces a
namespace_separatoroption. The implementation seems to be working, but since I’m not deeply familiar with the codebase, tests, or documentation conventions, I’d really appreciate your input.Your feedback would be super helpful in making this PR production-ready—we're relying on this feature and would love to get it merged.
Thanks in advance! 🙏