Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set timeout error as training error #498

Merged
merged 1 commit into from
Dec 17, 2020

Conversation

maikia
Copy link
Contributor

@maikia maikia commented Dec 17, 2020

Previously I set the timeout error to checking_error. This should not be the case. Conda workers considers timeout as training error and AWS worker does not have the timeout error implemented at all. (hence #497)

Weirdly tests which should have been failing on Ci passed on previous PR (#495) and failed only for the release PR (https://github.com/paris-saclay-cds/ramp-board/tree/0.7.X).

Once this is corrected, and if green another bug release will be made

@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #498 (bce2704) into master (e9a3c1d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #498      +/-   ##
==========================================
- Coverage   93.65%   93.64%   -0.02%     
==========================================
  Files          99       99              
  Lines        8633     8633              
==========================================
- Hits         8085     8084       -1     
- Misses        548      549       +1     
Impacted Files Coverage Δ
ramp-engine/ramp_engine/dispatcher.py 97.61% <100.00%> (ø)
ramp-engine/ramp_engine/base.py 92.68% <0.00%> (-1.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9a3c1d...bce2704. Read the comment docs.

@maikia maikia merged commit b2bd7e3 into paris-saclay-cds:master Dec 17, 2020
maikia added a commit that referenced this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant