feat: punish malicious peers #16818
Merged
feat: punish malicious peers #16818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varun-doshi
force-pushed
the
varun/punish-peer
branch
from
34f17f1 to
47779d7
Compare
0xMushow
reviewed
Jun 15, 2025
| @@ -965,6 +969,10 @@ impl<N: NetworkPrimitives> TransactionFetcher<N> { | |||
|
|
|||
| let transactions = valid_payload.into_data().into_values().collect(); | |||
|
|
|||
| if has_bad_transactions { | |||
| self.remove_peer(&peer_id); | |||
There was a problem hiding this comment.
As you mentioned in your PR, I don't think we immediately want to disconnect, rather just report_peer to decrease his score. It would be ideal to keep the same actions and consistency across the codebase. Could you implement what's needed? :)
emhane
added
D-good-first-issue
mattsse
approved these changes
Jun 26, 2025
|
thanks @mattsse :) ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #16807
Currently removes peer for malicious activity, but maybe thats not ideal and we just want to report peer. But for that, we would need to introduce
NetworkHandlein theTransactionFetcher. Will proceed as advised.