Skip to content

Chore: auto-generate translation strings #9462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2025
Merged

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Mar 23, 2025

Proposed change

Would be good to leave these off of the PRs, make the PRs cleaner. Downside, I suppose is if they somehow cause an error, but that seems rare.

This commits directly to dev, could be changed to open a PR of course.

Edit: Added PAT because of https://github.com/marketplace/actions/git-auto-commit#push-to-protected-branches

Example run: https://github.com/paperless-ngx/paperless-ngx/actions/runs/14016242452 which generated: a2a19fb

Closes #(issue or discussion)

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature / Enhancement: non-breaking change which adds functionality. Please read the important note above.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain:

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner March 23, 2025 06:27
@paperless-ngx-secretary paperless-ngx-secretary bot added ci-cd non-trivial Requires approval by several team members labels Mar 23, 2025
@shamoon shamoon enabled auto-merge (squash) March 23, 2025 06:27
@github-actions github-actions bot added the enhancement New feature or enhancement label Mar 23, 2025
Copy link

codecov bot commented Mar 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.77%. Comparing base (7a07f1e) to head (5667325).
Report is 104 commits behind head on dev.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##              dev    #9462    +/-   ##
========================================
  Coverage   97.77%   97.77%            
========================================
  Files         508      508            
  Lines       21767    21767            
  Branches     1821     1697   -124     
========================================
  Hits        21283    21283            
- Misses        482      484     +2     
+ Partials        2        0     -2     
Components Coverage Δ
backend 96.61% <ø> (ø)
frontend 99.04% <ø> (ø)
Flag Coverage Δ
backend-python-3.10 96.61% <ø> (ø)
backend-python-3.11 96.61% <ø> (ø)
backend-python-3.12 96.61% <ø> (ø)
frontend-node-20.x 99.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@shamoon shamoon added development and removed enhancement New feature or enhancement labels Mar 23, 2025
Copy link
Contributor

@tooomm tooomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see you picking this up after our conversation in b0390a9.


Oh I hadn’t thought about the notification to translators. Are they annoying?

Well, if they are constantly send because just a single string got adjusted, or several ones a day because various changes get merged...
Yes, I would not be too happy about it and I would prefer to be informed of a relevant amount of changes to look into or before a release for example. That's why I suggested scheduled runs and a manual dispatch trigger over each push.

But again, not exactly sure how the CrowdIn service is handling this.

@stumpylog
Copy link
Member

So this replaces updating the .po files in a PR?

@shamoon
Copy link
Member Author

shamoon commented Apr 21, 2025

Yea exactly, and the .xlf for the frontend. Idea is to keep the PRs clean of that cruft and also just let it automatically happen so we dont forget or have to deal with it (I mean famous last words, but that is the idea...)

@github-project-automation github-project-automation bot moved this from Todo to Reviewed in Paperless-ngx Apr 23, 2025
@shamoon shamoon disabled auto-merge April 23, 2025 16:30
@shamoon shamoon merged commit 6d8c507 into dev Apr 23, 2025
31 checks passed
@shamoon shamoon deleted the feature-auto-translate-strings branch April 23, 2025 16:30
@github-project-automation github-project-automation bot moved this from Reviewed to Done in Paperless-ngx Apr 23, 2025
@shamoon
Copy link
Member Author

shamoon commented Apr 23, 2025

Oh hey, it worked!
https://github.com/paperless-ngx/paperless-ngx/actions/runs/14623285673/job/41028553219 --> e277a8e

We'll see if needs any refinement...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd development non-trivial Requires approval by several team members
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants