New external tool upgrade script #22064
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f87cb21.
grihabor
force-pushed
the
upgrade-external-tool-script
branch
from
0d1af21 to
a8de875
Compare
lilatomic
approved these changes
Mar 13, 2025
| @@ -42,8 +41,8 @@ class PexCli(TemplatedExternalTool): | |||
| name = "pex" | |||
| help = "The PEX (Python EXecutable) tool (https://github.com/pex-tool/pex)." | |||
|
|
|||
| default_version = "v2.33.1" | |||
| default_url_template = "https://github.com/pex-tool/pex/releases/download/{version}/pex" | |||
| default_version = "2.33.1" | |||
There was a problem hiding this comment.
For tfsec, we added a deprecation notice for changing the format of the version specifier, and then we used a function to convert it during the transition. We should at least call it out in the docs.
There was a problem hiding this comment.
Sure, created a separate pr #22090
| parser.add_argument( | ||
| "-w", | ||
| "--workers", | ||
| default=32, |
There was a problem hiding this comment.
could also use multiprocessing.cpu_count()
grihabor
commented
Mar 17, 2025
| @@ -42,8 +41,8 @@ class PexCli(TemplatedExternalTool): | |||
| name = "pex" | |||
| help = "The PEX (Python EXecutable) tool (https://github.com/pex-tool/pex)." | |||
|
|
|||
| default_version = "v2.33.1" | |||
| default_url_template = "https://github.com/pex-tool/pex/releases/download/{version}/pex" | |||
| default_version = "2.33.1" | |||
There was a problem hiding this comment.
Sure, created a separate pr #22090
| parser.add_argument( | ||
| "-w", | ||
| "--workers", | ||
| default=32, |
huonw
added a commit
that referenced
this pull request
Mar 17, 2025
The pr was generated with this command: ``` pants run build-support/bin:external-tool-upgrade -- -v src/python/pants/backend/ ``` (Notes are not generated yet) The tool code is here #22064 --------- Co-authored-by: Huon Wilson <[email protected]>
lilatomic
reviewed
Apr 22, 2025
| @@ -25,14 +25,14 @@ class Cue(TemplatedExternalTool): | |||
| Homepage: https://cuelang.org/ | |||
| """ | |||
| ) | |||
| default_version = "v0.4.3" | |||
| default_version = "0.4.3" | |||
There was a problem hiding this comment.
Sorry, I missed this the first time. Same as #22064 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's hard to upgrade external tools versions, because it's not supported by tools like dependabot. This new script solves this problem, it fetches the latest release from github.com or k8s.io and modifies
default_known_versionsin python sources code.Example of upgraded tools here #22065