Skip to content

SELFS-1359 Update .rubocop.yml to read from panolint #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,18 @@ jobs:
matrix:
# Due to https://github.com/actions/runner/issues/849, we have to use
# quotes for '3.0'. Without quotes, CI runs 3.1.
ruby: [ 2.5, 2.6, 2.7, '3.0', 3.1, jruby ]
ruby: [ jruby, truffleruby, 2.5, 2.6, 2.7, '3.0', 3.1 ]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2

# Conditionally configure bundler via environment variables as advised
# * https://github.com/ruby/setup-ruby#bundle-config
- name: Set bundler environment variables
run: |
echo "BUNDLE_WITHOUT=checks" >> $GITHUB_ENV
if: matrix.ruby != 3.1

# Use 'bundler-cache: true' instead of actions/cache as advised:
# * https://github.com/actions/cache/blob/main/examples.md#ruby---bundler
- uses: ruby/setup-ruby@v1
Expand All @@ -29,4 +36,4 @@ jobs:
- run: bundle exec rspec

- run: bundle exec rubocop
if: matrix.ruby == 3.0
if: matrix.ruby == 3.1
2 changes: 1 addition & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
inherit_gem:
panolint: rubocop.yml
panolint: panolint-rubocop.yml
Metrics/BlockLength:
Exclude:
- scan_left.gemspec
Expand Down
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@ git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
# Specify your gem's dependencies in scan_left.gemspec
gemspec

group :development do
group :checks do
gem "panolint", github: "panorama-ed/panolint", branch: "main"
end
53 changes: 27 additions & 26 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
GIT
remote: https://github.com/panorama-ed/panolint
revision: c709ebcc5fd9593db959df4a92c12cae1d1fb9af
revision: 0e9b6d9f2d41c84c306cae5f33da53f58aa61678
branch: main
specs:
panolint (0.1.3)
panolint (0.1.5)
brakeman (>= 4.8, < 6.0)
rubocop (>= 0.83, < 2.0)
rubocop-performance (~> 1.5)
Expand All @@ -19,25 +19,26 @@ PATH
GEM
remote: https://rubygems.org/
specs:
activesupport (6.1.4)
activesupport (6.1.7)
concurrent-ruby (~> 1.0, >= 1.0.2)
i18n (>= 1.6, < 2)
minitest (>= 5.1)
tzinfo (~> 2.0)
zeitwerk (~> 2.3)
ast (2.4.2)
brakeman (5.1.1)
concurrent-ruby (1.1.9)
brakeman (5.3.1)
concurrent-ruby (1.1.10)
diff-lcs (1.4.4)
i18n (1.8.10)
i18n (1.12.0)
concurrent-ruby (~> 1.0)
minitest (5.14.4)
parallel (1.20.1)
parser (3.0.2.0)
json (2.6.2)
minitest (5.15.0)
parallel (1.22.1)
parser (3.1.2.1)
ast (~> 2.4.1)
rack (2.2.3)
rainbow (3.0.0)
regexp_parser (2.1.1)
rack (3.0.0)
rainbow (3.1.1)
regexp_parser (2.6.0)
rexml (3.2.5)
rspec (3.10.0)
rspec-core (~> 3.10.0)
Expand All @@ -52,34 +53,34 @@ GEM
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.10.0)
rspec-support (3.10.0)
rubocop (1.18.4)
rubocop (1.36.0)
json (~> 2.3)
parallel (~> 1.10)
parser (>= 3.0.0.0)
parser (>= 3.1.2.1)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 1.8, < 3.0)
rexml
rubocop-ast (>= 1.8.0, < 2.0)
rexml (>= 3.2.5, < 4.0)
rubocop-ast (>= 1.20.1, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 1.4.0, < 3.0)
rubocop-ast (1.8.0)
parser (>= 3.0.1.1)
rubocop-performance (1.11.4)
rubocop-ast (1.21.0)
parser (>= 3.1.1.0)
rubocop-performance (1.13.3)
rubocop (>= 1.7.0, < 2.0)
rubocop-ast (>= 0.4.0)
rubocop-rails (2.11.3)
rubocop-rails (2.14.2)
activesupport (>= 4.2.0)
rack (>= 1.1)
rubocop (>= 1.7.0, < 2.0)
rubocop-rake (0.6.0)
rubocop (~> 1.0)
rubocop-rspec (2.4.0)
rubocop (~> 1.0)
rubocop-ast (>= 1.1.0)
rubocop-rspec (2.10.0)
rubocop (~> 1.19)
ruby-progressbar (1.11.0)
tzinfo (2.0.4)
tzinfo (2.0.5)
concurrent-ruby (~> 1.0)
unicode-display_width (2.0.0)
zeitwerk (2.4.2)
unicode-display_width (2.3.0)
zeitwerk (2.6.0)

PLATFORMS
ruby
Expand Down
1 change: 1 addition & 0 deletions scan_left.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,5 @@ Gem::Specification.new do |spec|
spec.require_paths = ["lib"]

spec.add_development_dependency "rspec", "~> 3.0"
spec.metadata["rubygems_mfa_required"] = "true"
end