Skip to content

SELFS-1359 Update .rubocop.yml #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2021
Merged

SELFS-1359 Update .rubocop.yml #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02dfafc
Update .rubocop.yml
PeteHanner Nov 23, 2021
3951c23
Fix RuboCop warnings
JacobEvelyn Nov 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
inherit_gem:
panolint: rubocop.yml
panolint: panolint-rubocop.yml

Layout/LineLength:
Max: 120
Expand Down
52 changes: 26 additions & 26 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
GIT
remote: https://github.com/panorama-ed/panolint.git
revision: c709ebcc5fd9593db959df4a92c12cae1d1fb9af
revision: 5850a218b96da7dd196438fb65d41169cd6747e5
branch: main
specs:
panolint (0.1.3)
panolint (0.1.4)
brakeman (>= 4.8, < 6.0)
rubocop (>= 0.83, < 2.0)
rubocop-performance (~> 1.5)
Expand All @@ -19,14 +19,15 @@ PATH
GEM
remote: https://rubygems.org/
specs:
activesupport (5.2.6)
activesupport (6.1.4.1)
concurrent-ruby (~> 1.0, >= 1.0.2)
i18n (>= 0.7, < 2)
minitest (~> 5.1)
tzinfo (~> 1.1)
i18n (>= 1.6, < 2)
minitest (>= 5.1)
tzinfo (~> 2.0)
zeitwerk (~> 2.3)
ansi (1.5.0)
ast (2.4.2)
brakeman (5.1.1)
brakeman (5.1.2)
codecov (0.6.0)
simplecov (>= 0.15, < 0.22)
concurrent-ruby (1.1.9)
Expand All @@ -36,11 +37,11 @@ GEM
ansi
rouge
slop (~> 3)
i18n (1.8.10)
i18n (1.8.11)
concurrent-ruby (~> 1.0)
minitest (5.14.4)
parallel (1.20.1)
parser (3.0.2.0)
parallel (1.21.0)
parser (3.0.3.1)
ast (~> 2.4.1)
rack (2.2.3)
rainbow (3.0.0)
Expand All @@ -62,44 +63,43 @@ GEM
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.10.0)
rspec-support (3.10.0)
rubocop (1.12.1)
rubocop (1.23.0)
parallel (~> 1.10)
parser (>= 3.0.0.0)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 1.8, < 3.0)
rexml
rubocop-ast (>= 1.2.0, < 2.0)
rubocop-ast (>= 1.12.0, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 1.4.0, < 3.0)
rubocop-ast (1.4.1)
parser (>= 2.7.1.5)
rubocop-performance (1.10.2)
rubocop (>= 0.90.0, < 2.0)
rubocop-ast (1.13.0)
parser (>= 3.0.1.1)
rubocop-performance (1.12.0)
rubocop (>= 1.7.0, < 2.0)
rubocop-ast (>= 0.4.0)
rubocop-rails (2.9.1)
rubocop-rails (2.12.4)
activesupport (>= 4.2.0)
rack (>= 1.1)
rubocop (>= 0.90.0, < 2.0)
rubocop-rake (0.5.1)
rubocop
rubocop-rspec (2.2.0)
rubocop (>= 1.7.0, < 2.0)
rubocop-rake (0.6.0)
rubocop (~> 1.0)
rubocop-ast (>= 1.1.0)
rubocop-rspec (2.6.0)
rubocop (~> 1.19)
ruby-progressbar (1.11.0)
simplecov (0.18.5)
docile (~> 1.1)
simplecov-html (~> 0.11)
simplecov-html (0.12.3)
slop (3.6.0)
thread_safe (0.3.6)
tzinfo (1.2.9)
thread_safe (~> 0.1)
unicode-display_width (2.0.0)
tzinfo (2.0.4)
concurrent-ruby (~> 1.0)
unicode-display_width (2.1.0)
values (1.8.0)
yard (0.9.26)
yard-doctest (0.1.17)
minitest
yard
zeitwerk (2.5.1)

PLATFORMS
ruby
Expand Down
1 change: 1 addition & 0 deletions memo_wise.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ Gem::Specification.new do |spec| # rubocop:disable Metrics/BlockLength
spec.require_paths = ["lib"]

spec.metadata = {
"rubygems_mfa_required" => "true",
"changelog_uri" => "https://github.com/panorama-ed/memo_wise/blob/main/CHANGELOG.md",
"source_code_uri" => "https://github.com/panorama-ed/memo_wise"
}
Expand Down
8 changes: 4 additions & 4 deletions spec/memo_wise_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,9 +554,9 @@ def test_method

it "memoizes each extended class separately" do
aggregate_failures do
expect(class_a_extending_module_with_memo.test_method).
expect(class_a_extending_module_with_memo.test_method). # rubocop:disable RSpec/IdenticalEqualityAssertion
to eq(class_a_extending_module_with_memo.test_method)
expect(class_b_extending_module_with_memo.test_method).
expect(class_b_extending_module_with_memo.test_method). # rubocop:disable RSpec/IdenticalEqualityAssertion
to eq(class_b_extending_module_with_memo.test_method)
expect(class_a_extending_module_with_memo.test_method).
to_not eq(class_b_extending_module_with_memo.test_method)
Expand Down Expand Up @@ -623,8 +623,8 @@ def test_method

it "memoizes instance and singleton methods separately" do
aggregate_failures do
expect(instance.test_method).to eq(instance.test_method)
expect(module_with_memo.test_method).to eq(module_with_memo.test_method)
expect(instance.test_method).to eq(instance.test_method) # rubocop:disable RSpec/IdenticalEqualityAssertion
expect(module_with_memo.test_method).to eq(module_with_memo.test_method) # rubocop:disable RSpec/IdenticalEqualityAssertion
expect(instance.test_method).to_not eq(module_with_memo.test_method)
end
end
Expand Down