Flask-SQLAlchemy 3 compatibility

[Dosenpfand]

Addresses #185, adds support for flask_sqlalchemy >= 3.0.0

[nickjj]

Should we keep this in as a comment with a callout for folks using SQLAlchemy 2.X?

Something like:

# This is no longer needed for Flask-SQLAlchemy 3.0+, if you're using 2.X you'll want to define this:
# app.config['SQLALCHEMY_TRACK_MODIFICATIONS'] = False

[Dosenpfand]

Yes, probably the safer approach to leave it in. I re-added it here and in the test app.
Changed to your proposal for both test and example.

[nickjj]

@davidism, do you have any last minute feedback before I merge this one in? Based on your PR's bullets I think it hits all of the marks.

[nickjj]

Typo: ist should be is

[Dosenpfand]

Fixed

[davidism]

Looks good. You could set SQLALCHEMY_RECORD_QUERIES to True if debug mode is enabled during init_app. The user could always disable it again after that. But I wouldn't unconditionally enable it, that would be annoying if they still had the extension installed outside debug mode.

[nickjj]

Thanks. If it defaults to true if debug mode is on, I wonder if we should remove this:

        if not app.config.get("SQLALCHEMY_RECORD_QUERIES", False):
            app.logger.warning(
                "'SQLALCHEMY_RECORD_QUERIES' is not set to True. SQL query logging will not be available.")

Because in theory DBT would expect debug mode to be enabled to function.

[Dosenpfand]

I added SQLALCHEMY_RECORD_QUERIES to the default config and removed the warning.

[nickjj]

Thanks, are you feeling good to merge this @Dosenpfand? I think it's ready.

[Dosenpfand]

Yes @nickjj, looks good to me.

[nickjj]

Thanks a lot for the contribution.