Skip to content

S3FileAdmin runs on (old) boto. #2347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
israel-oye opened this issue Mar 28, 2023 · 1 comment · Fixed by #2552
Closed

S3FileAdmin runs on (old) boto. #2347

israel-oye opened this issue Mar 28, 2023 · 1 comment · Fixed by #2552
Labels
dependencies Pull requests that update a dependency file files

Comments

@israel-oye
Copy link

https://github.com/flask-admin/flask-admin/blob/46d5a6ee5dd4d298c8824047a4cd9f7cc404348a/flask_admin/contrib/fileadmin/s3.py#L4

boto is no more maintained and it has been replaced by the latest boto3 library.
I'm surprised that this issue has not been raised earlier but I guess not many people use the S3FileAdmin layer for their Flask-Admin. I would be happy to contribute to updating the S3FileAdmin add-on but I need to get a hang of it's documentation.
Added to my to-do!
I'm sure @metadaddy will be willing to help.
@samuelhwilliams samuelhwilliams added the dependencies Pull requests that update a dependency file label Jul 6, 2024
@samuelhwilliams
Copy link
Contributor

Would be happy to accept a pull request for this :)

@samuelhwilliams samuelhwilliams mentioned this issue Jul 6, 2024
Closed
emilazy added a commit to emilazy/nixpkgs that referenced this issue Sep 22, 2024
@emilazy
python3{11,12}.flask-admin: drop optional boto dependency
a044fea 
Pending migration to boto3:
<pallets-eco/flask-admin#2347>.
@samuelhwilliams samuelhwilliams mentioned this issue Oct 26, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file files
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use boto3 for S3 fileadmin pallets-eco/flask-admin
2 participants
@samuelhwilliams @israel-oye