Skip to content

fix(client): determine the last_id by finding the maximum Id in the list #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2025

Conversation

palazzem
Copy link
Owner

Related Issues

Proposed Changes:

This change removes the assumption that items ID returned from the Cloud API, are ordered.

Testing:

Home Assistant integration polling should work again.

Extra Notes (optional):

n/a

Checklist

  • Related issues and proposed changes are filled
  • Tests are defining the correct and expected behavior
  • Code is well-documented via docstrings

@palazzem palazzem added this to the 0.12.1 milestone Apr 12, 2025
@palazzem palazzem self-assigned this Apr 12, 2025
@palazzem palazzem moved this to In Progress in e-Connect Roadmap Apr 12, 2025
@coveralls
Copy link

coveralls commented Apr 12, 2025

Pull Request Test Coverage Report for Build 14421885397

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 14421769847: 0.0%
Covered Lines: 399
Relevant Lines: 399

💛 - Coveralls

@palazzem palazzem merged commit 276192b into main Apr 12, 2025
4 checks passed
@palazzem palazzem deleted the palazzem/fix-154 branch April 12, 2025 17:37
@github-project-automation github-project-automation bot moved this from In Progress to Done in e-Connect Roadmap Apr 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

last_id key for sectors, inputs and outputs doesn't point to the right last ID
2 participants