Skip to content

upgrade karma deps #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Conversation

pgoldberg
Copy link
Contributor

Before this PR

Necessary to unblock #151

When trying to run karma integration tests after switching to using web-streams-polyfill/ponyfill, I was getting an obscure error:

19 08 2022 23:19:58.878:INFO [compiler.karma-typescript]: Compiling project using Typescript 3.2.4
19 08 2022 23:20:01.579:INFO [compiler.karma-typescript]: Compiled 58 files in 2674 ms.
19 08 2022 23:20:02.169:ERROR [karma]: { inspect: [Function: inspect] }
error Command failed with exit code 1.

After googling it, I found this comment, karma-runner/karma#3764 (comment). I set a breakpoint at the place the comment mentioned, and saw this error:

'Unable to resolve module [web-streams-polyfill/dist/types] from [/Volumes/git/conjure-typescript-runtime/packages/conjure-client/src/fetchBridge/blobReadableStreamAdapter.js

This seemed pretty strange to me, and after playing around with it for a while without being able to resolve it, I just tried bumping karma-typescript, which fixed the issue. That caused some deprecation warnings, so I bumped karma to resolve those. Then I figured I might as well upgrade all of the karma-related deps to latest (I checked the changelogs, doesn't look like there are any major breaks that would affect us).

I didn't dig too much more into what caused the problem, but I'm guessing it's the bug that this PR resolved: monounity/karma-typescript#437

After this PR

==COMMIT_MSG==
Upgrade karma dependencies
==COMMIT_MSG==

Possible downsides?

@pgoldberg pgoldberg force-pushed the pgoldberg/upgradeKarmaDeps branch from 4c355ad to 3c2faa3 Compare August 20, 2022 06:08
@gluxon gluxon self-assigned this Aug 22, 2022
Copy link
Contributor

@gluxon gluxon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't dig too much more into what caused the problem, but I'm guessing it's the bug that this PR resolved: monounity/karma-typescript#437

That does look like a very likely cause. Thanks for investigating!

@pgoldberg pgoldberg merged commit 70547a6 into palantir:develop Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants