Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Necessary to unblock #151
When trying to run karma integration tests after switching to using
web-streams-polyfill/ponyfill
, I was getting an obscure error:After googling it, I found this comment, karma-runner/karma#3764 (comment). I set a breakpoint at the place the comment mentioned, and saw this error:
This seemed pretty strange to me, and after playing around with it for a while without being able to resolve it, I just tried bumping
karma-typescript
, which fixed the issue. That caused some deprecation warnings, so I bumpedkarma
to resolve those. Then I figured I might as well upgrade all of the karma-related deps to latest (I checked the changelogs, doesn't look like there are any major breaks that would affect us).I didn't dig too much more into what caused the problem, but I'm guessing it's the bug that this PR resolved: monounity/karma-typescript#437
After this PR
==COMMIT_MSG==
Upgrade karma dependencies
==COMMIT_MSG==
Possible downsides?