Skip to content

Fix windows build #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 2, 2025
Merged

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Jun 24, 2025

D:\a\ros2_control\ros2_control\src\pal_statistics\pal_statistics\src\registration_list.hpp(38,10): error C1083: Cannot open include file: 'boost/bimap.hpp': No such file or directory [D:\a\ros2_control\ros2_control\build\pal_statistics\pal_statistics.vcxproj]
  (compiling source file '../../src/pal_statistics/pal_statistics/src/registration_list.cpp')
  
D:\a\ros2_control\ros2_control\src\pal_statistics\pal_statistics\src\lock_free_queue.hpp(33,10): error C1083: Cannot open include file: 'boost/lockfree/queue.hpp': No such file or directory [D:\a\ros2_control\ros2_control\build\pal_statistics\pal_statistics.vcxproj]

It needs to be linked against Boost::boost, and explict find_package for boost on windows.

Building the tests throw lots of errors, I disabled it now in the ros2_control workflow.

closes #17

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Noel Jiménez García <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants