-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade requests from 2.31.0 to 2.32.4 #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-REQUESTS-10305723
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @paaschdigital, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request implements an automated security fix by upgrading the requests
library dependency to a newer version. The change is limited to updating the version constraint in the requires-testing.txt
file to mitigate identified vulnerabilities.
Highlights
- Automated Security Upgrade: This pull request was automatically created by Snyk to address security vulnerabilities found in the project's dependencies.
- Requests Library Upgrade: The primary change involves upgrading the
requests
Python library to version2.32.4
. - Dependency Specification Change: The dependency specification for
requests
inrequires-testing.txt
was updated, removing the[security]
extra and setting the minimum version to2.32.4
. - Potential Dependency Warning: The Snyk description includes a warning that
percy 2.0.2
requiresrequests
, which might indicate a potential dependency conflict or issue to investigate after the upgrade.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, upgrades the requests
library from version 2.31.0
to 2.32.4
in requires-testing.txt
. This change aims to address the security vulnerability SNYK-PYTHON-REQUESTS-10305723
.
The primary point for review is the removal of the [security]
extra from the requests
dependency. This extra previously ensured the presence of packages like pyOpenSSL
and cryptography
. While modern Python versions (3.8+ as used here) have strong native SSL/TLS capabilities, it's important to confirm that no tests relied on specific functionalities that pyOpenSSL
provided. A detailed comment has been added to the requires-testing.txt
file regarding this.
Additionally, please note the warning in the Snyk PR description: percy 2.0.2 requires requests, which is not installed.
While this might be a false positive from Snyk's pre-analysis (as requests
is indeed being specified in requires-testing.txt
), it would be prudent to ensure that percy
integration and related tests continue to function as expected after this upgrade.
@@ -4,7 +4,7 @@ cryptography<3.4;python_version<"3.7" | |||
lxml>=4.6.2 | |||
percy>=2.0.2 | |||
pytest>=6.0.2 | |||
requests[security]>=2.21.0 | |||
requests>=2.32.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The upgrade to requests>=2.32.4
also removes the [security]
extra. This extra previously installed pyOpenSSL
and cryptography
(among others like idna
and certifi
, which are now dependencies of the base requests
package).
While requests
on Python 3.8+ (as used in this project, specified by python_requires=">=3.8"
in setup.py
) has robust built-in SSL/TLS support via the standard ssl
module, pyOpenSSL
can offer different capabilities (e.g., additional cipher suites, different TLS negotiation behavior, or specific client certificate handling) by injecting itself into urllib3
(which requests
uses).
Please verify that all testing scenarios, especially those involving HTTPS requests to servers with specific or non-standard TLS configurations, continue to pass. If any tests relied on features uniquely provided by pyOpenSSL
, then pyOpenSSL
(and potentially cryptography
) might need to be added as explicit dependencies in this file.
Snyk has created this PR to fix 1 vulnerabilities in the pip dependencies of this project.
Snyk changed the following file(s):
requires-testing.txt
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.