fixed/shorted-use(fix #5176) #5223
Conversation
Signed-off-by: Akarsh Sahlot <[email protected]>
Signed-off-by: Akarsh Sahlot <[email protected]>
|
I tried to run cmake to build the updated compiler, for its building since day before yesterday, |
fruffy
added
the
core
| frontends/p4/p4-lex.c | ||
| frontends/p4/p4-parse.cpp | ||
| py-compile | ||
|
|
There was a problem hiding this comment.
You should not remove this file
There was a problem hiding this comment.
ok I will add it back
| @@ -19,6 +19,10 @@ limitations under the License. | |||
| #include "lib/null.h" | |||
|
|
|||
| namespace P4 { | |||
| void Util::Options::shortUsage() { | |||
| *outStream << binaryName << ": Error in command line options" << std::endl; | |||
There was a problem hiding this comment.
There should have already been printed an error message like "Unknown option --x" or "Option --x is missing a required argument", so this line of output seems redundant.
To start with you could post your error output to see what's wrong. Try to get everything working locally first. |
| @@ -68,7 +72,7 @@ std::vector<const char *> *Util::Options::process(int argc, char *const argv[]) | |||
| if (!option && (arg = opt.find('='))) option = get(options, opt.before(arg++)); | |||
| if (option == nullptr) { | |||
| ::P4::error(ErrorType::ERR_UNKNOWN, "Unknown option %1%", opt); | |||
| usage(); | |||
| shortUsage(); | |||
There was a problem hiding this comment.
| shortUsage(); | |
| shortUsage(); |
Right now, when we type a wrong command like p4c --wrong-option, the program shows a huge help message with all options. We want to make it show just a short error message that tells you to use --help.
changes needed that I have done:
Added a new function shortUser that shows a short error message (instead of the long help previous message error).
I Replaced all locations where usage() is called on errors with this new shortUser() message.
Fixes #5176