Formatting fixes #703
Merged
Formatting fixes #703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnfoster
approved these changes
Nov 30, 2018
jnfoster
requested changes
Nov 30, 2018
There was a problem hiding this comment.
How so? I'm not sure what @jafingerhut intended, but this table looks okay to me.
|
@jnfoster I tried building with the current version, and with Mihai's proposed changes. The PDF file generated looks the same for both, but the HTML looks better with these changes than without them. With them, the top border line of the table looks normal. Without them, the top border line is incomplete. |
|
Ahh, I'd only checked the PDF based on the commit comment. |
jnfoster
approved these changes
Nov 30, 2018
|
I don't know whether Mihai replaced "HTML" with "PDF" by accident in his comment, or perhaps he is getting different output than we are for the PDF. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pdf tables were rendered wrong without these fixes.