Skip to content

Bump version to 1.5.0 #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 20, 2023
Merged

Bump version to 1.5.0 #100

merged 3 commits into from
Feb 20, 2023

Conversation

edisonhello
Copy link
Contributor

Since there're some bug fixes and performance improvements, I don't know if you want to upgrade the library to the 1.5.0 version.

By the way, I realized that the .clang-format file isn't properly used in the script clang-format.bash (which uses an inlined style when calling clang-format). Do you have any preference about which one to keep?

@p-ranav
Copy link
Owner

p-ranav commented Feb 13, 2023

Thanks! Yes, I agree it's time for 1.5.0. I think I prefer the clang-format.bash version with a 100 column limit. Perhaps we can simply change the .clang-format file to match it, so that there isn't this inconsistency.

@edisonhello edisonhello force-pushed the upgrade/bump-1.5 branch 4 times, most recently from 79a67df to 413c02e Compare February 20, 2023 05:19
@edisonhello
Copy link
Contributor Author

edisonhello commented Feb 20, 2023

Sure. .clang-format and the script clang-format.bash are both updated. Also, I avoid the script from formatting the {variant,string_view,optional}_lite.hpp files as they are actually external files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants