Add Java equality and hash functions to machines in pobser… #861
+45
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve mode Generate deepEquals(), equals(), and hashCode() methods in the Java code for events and machines when compiled in pobserve mode.
ankushdesai
reviewed
May 14, 2025
|
This is to enable the structural comparison we wanted to add for checker state validation in PObserve. |
ankushdesai
reviewed
May 14, 2025
| WriteLine(); | ||
| WriteLine("public boolean equals(Object other) {"); | ||
| Write("return this.getClass() == other.getClass()"); | ||
| if (hasPayload) |
There was a problem hiding this comment.
May be I am missing something here, why can we not achieve this at the base class level?
There was a problem hiding this comment.
My mistake, it looks like it is handled in the base class.
lewisbru
changed the title
ankushdesai
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ve mode
Generate deepEquals(), equals(), and hashCode() methods in the Java code for machines when compiled in pobserve mode.