Dev/pex refactoring #853
Closed
Dev/pex refactoring #853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankushdesai
requested review from
aman-goel,
Copilot,
aishu-j and
ChristineZh0u
There was a problem hiding this comment.
Pull Request Overview
This PR refactors execution and error handling logic in the PEx runtime while enhancing test driver initialization.
- Refactored RuntimeExecutor code: streamlined thread cancellation, task monitoring, and exception handling with helper methods.
- Updated PEx main and auxiliary methods: improved environment initialization and error messaging for driver selection and runtime errors.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Src/PEx/src/main/java/pex/RuntimeExecutor.java | Refactored thread management, task monitoring, and error handling functions. |
| Src/PEx/src/main/java/pex/PEx.java | Enhanced environment initialization, test driver lookup, and exit code handling. |
Files not reviewed (1)
- Src/PEx/pom.xml: Language not supported
| * @param resultException Exception to store any error encountered | ||
| * @return true if all tasks are completed | ||
| */ | ||
| private static boolean checkAndProcessCompletedTasks(Set<Integer> completedTasks, Exception resultException) { |
There was a problem hiding this comment.
The method 'checkAndProcessCompletedTasks' reassigns the parameter 'resultException' in the catch blocks, but these changes will not propagate back to the caller due to Java's pass-by-value semantics. Consider using a mutable wrapper for the exception or returning an object that encapsulates both the completion status and any exception encountered.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.