Added better error messages for assertion and ran auto code cleanup. #831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -148,19 +148,19 @@ private async Task CreateTaskFromProcess(Process proc) | |||
| switch (proc.ExitCode) | |||
| { | |||
| case 0: | |||
| Logger.WriteLine($"... Checker run finished."); | |||
| _logger.WriteLine("... Checker run finished."); | |||
There was a problem hiding this comment.
In future code, should we format all private fields to be: _fieldName?
| @@ -534,12 +533,12 @@ protected StateMachineId CreateStateMachine(Type type, string name, Event initia | |||
| /// <param name="opGroupId">Optional id that can be used to identify this operation.</param> | |||
| public void SendEvent(PMachineValue target, Event ev) | |||
| { | |||
| Assert(ev != null, "Machine cannot send a null event"); | |||
| Assert(target != null, "Machine in send cannot be null"); | |||
| Assert(ev != null, $"Machine cannot send a null event. Machine {Id} trying to send null event in state {CurrentStateName}."); | |||
There was a problem hiding this comment.
Don't think this assertion will ever be false. When I try to send a null event it gets caught by the compiler.
ChristineZh0u
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.