Skip to content

try wasm-bindgen fixes #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

try wasm-bindgen fixes #2

wants to merge 1 commit into from

Conversation

ozabalaferrera
Copy link
Owner

No description provided.

@smoelius
Copy link

smoelius commented Dec 3, 2024

The command that failed was this one:

/home/runner/.cargo/bin/cargo +stable build --target wasm32-unknown-unknown --manifest-path ./example-projects/reqwest-wasm-example/Cargo.toml

So I think the failure is caused by this line:

See: https://github.com/smoelius/cloudevents-sdk-rust/actions/runs/12137884805/job/33842119071

Good luck!

Signed-off-by: Omar Zabala-Ferrera <[email protected]>
@ozabalaferrera
Copy link
Owner Author

Thanks @smoelius ! It looks like I had to change the edition on both the root, project manifest and the example project manifest. Other combinations of edition and resolver didn't seem to do it. I squashed to get this ready for a PR to the official repo. Thanks again.

@ozabalaferrera
Copy link
Owner Author

ozabalaferrera commented Dec 3, 2024

Looks like I lost my comment edits from before 🤔
It turns out that resolver="2" on both manifest does fix it. I had just accidentally removed the edition="2018" on the sample project, reverting it to a default of 2015, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants