Skip to content

Fix test failures with MOI 0.9.5 #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 16, 2019
Merged

Fix test failures with MOI 0.9.5 #98

merged 3 commits into from
Oct 16, 2019

Conversation

rschwarz
Copy link
Contributor

  • Exclude test "number_threads".
  • Fix some MOI methods for test "result_count".

@rschwarz
Exclude MOI unit test "number_threads".
c3d0263 
This test case is about the newly introduced attribute NumberOfThreads, which is
not (and can not be?) supported in COSMO. So we exclude the test to avoid the
overall failure.
@rschwarz
Fix MOI tests "result_count".
969cb2b 
In several MOI.get methods, check whether the result index in the attribute is
valid, using MOI.check_result_index_bounds.
@rschwarz
Bump MOI requirement in Project.toml
46ec397 
We are now using recently added MOI functions to check the result index.
@codecov-io
Copy link

codecov-io commented Oct 16, 2019 •
edited
Loading

Codecov Report

Merging #98 into master will increase coverage by 0.2%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #98     +/-   ##
=========================================
+ Coverage   89.66%   89.87%   +0.2%     
=========================================
  Files          22       22             
  Lines        1771     1777      +6     
=========================================
+ Hits         1588     1597      +9     
+ Misses        183      180      -3
Impacted Files Coverage Δ
src/MOIWrapper.jl 92.34% <88.88%> (+0.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39fdf69...46ec397. Read the comment docs.

@migarstka migarstka merged commit 857bf18 into oxfordcontrol:master Oct 16, 2019
@migarstka
Copy link
Member

Thanks for the PR!

@rschwarz rschwarz deleted the rs/moi095 branch October 17, 2019 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blegat blegat blegat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rschwarz @codecov-io @migarstka @blegat