Covering more cases in CI #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
There are definitely more subtle bugs uncovered by this. Up to the maintainers whether you want this covered or not. Overall it's not a good idea to over-constrain your methods when not for dispatch |
|
Thanks for flagging this. I'll add a 32-bit architecture to the CI. |
|
Do you want to go with this PR or should I close it? |
|
Thanks. I merged it and will add a few more changes on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI only runs on ubuntu and 64-bits architectures.
This caused some uncovered failures downstream (jump-dev/MatrixOptInterface.jl#13) because of the Int64-specific code.
It was basically replacing Int64 -> Int everywhere
Corrected that and fixed a warning in the test