Skip to content

Issue with MOI master #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
blegat opened this issue Sep 2, 2020 · 5 comments
Closed

Issue with MOI master #116

blegat opened this issue Sep 2, 2020 · 5 comments

Comments

@blegat
Copy link
Contributor

blegat commented Sep 2, 2020

See https://travis-ci.com/github/blegat/SolverTests/jobs/380241587#L510
and https://travis-ci.com/github/blegat/SolverTests/jobs/380241587#L539
The second issue is due to the use of the _pass_attributes internal function that changed its signature in jump-dev/MathOptInterface.jl#1121
@blegat
Copy link
Contributor Author

blegat commented Sep 2, 2020

I have updated the version number of the Project.toml on MOI master, so that you can use it to either branch in the code and call a different signature or simply require this new version in Project.toml.

migarstka added a commit that referenced this issue Sep 4, 2020
@migarstka
<#116> Make COSMO compatible to MOIv0.9.15
92a6fbc 
- Take the function signature change in `_pass_attributes` into account
- Update Project.toml to require MOI v0.9.15
@migarstka
Copy link
Member

migarstka commented Sep 4, 2020 •
edited
Loading

Thank you for the heads-up @blegat.

I changed the code in COSMO to account for the changes in _pass_attributes here: 92a6fbc

I guess I will wait until you release MOIv0.9.15 and then tag a new release for COSMO that requires that new version.

Somewhat unrelated: How difficult would it be to support VariableNames and ConstraintNames in the current wrapper?
Do you have any examples where they are used?

@blegat
Copy link
Contributor Author

blegat commented Sep 4, 2020

Supporting names is quite easy. The code in Utilities/model.jl is written such that it's easy to reuse by calling (non-internal) methods.
You can check Utilities/universalfallback.jl to see how to reuse these

@blegat
Copy link
Contributor Author

blegat commented Sep 16, 2020

MOI was release, I would recommend releasing a new version of COSMO asap as the current one is failing.

migarstka added a commit that referenced this issue Sep 17, 2020
@migarstka
<#116> Make COSMO compatible to MOIv0.9.15
8b377b6 
- Take the function signature change in `_pass_attributes` into account
- Update Project.toml to require MOI v0.9.15
migarstka added a commit that referenced this issue Sep 17, 2020
@migarstka
<#116> Make COSMO compatible with MOI v0.9.16
95dbdf9 
- Now that new MOI is released, we push this fix
- COSMO now requires MOI 0.9.16
@migarstka
Copy link
Member

I added the changes as discussed 8b377b6. New version will be tagged once the CI tests pass.

@1oly 1oly mentioned this issue Sep 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blegat @migarstka