server: delay transact commit #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1067601089
💛 - Coveralls |
Changes shouldn't be made to the db unless the we know the whole transaction will succeed. This commit changes the Database interface so table indexes can be checked before a transaction is committed. Once a transaciton is complete, it is commited to the database. This more closely mirrors how the real ovsdb-server works. In order for this to work, we needed a IndexExists function in the cache. Signed-off-by: Dave Tucker <[email protected]>
| } | ||
| db.mutex.RLock() | ||
| targetDb := db.databases[database] | ||
| db.mutex.RLock() |
There was a problem hiding this comment.
hi @dave-tucker . I am a little confused about the double db.mutex.RLock() call.
I see it in a couple of places in this file. Were they meant to be an unlock like
defer db.mutex.RUnlock() or a simple db.mutex.RUnlock() ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes shouldn't be made to the db unless the we know the whole
transaction will succeed.
This commit changes the Database interface so table indexes can be checked before a transaction is committed.
Once a transaciton is complete, it is commited to the database. This more closely mirrors how the real ovsdb-server works.
In order for this to work, we needed a IndexExists function in the cache.
Fixes: #196