fix bin/up with mongo change

[darvid7]

Description

fix bin/up setup

with #270 the prefix of the configuration shouldn't be in the return value.

On a new checkout I ran into

---------------------  ERROR  -----------------------
  Invalid MONGO_VERSION: MONGO_VERSION=6.0

  MONGO_VERSION must start with the actual major version of mongo, followed by a dot.
  Example: MONGO_IMAGE=my.dockerhub.com/custom-mongo
           MONGO_VERSION=6.0-custom
---------------------  ERROR  -----------------------

removing \1 fixed it.

Related issues / Pull Requests

Contributor Agreement

• I confirm I have signed the Contributor License Agreement

[darvid7]

@mserranom can I borrow your eyes on this? I think #270 changed the mongo config and the prefix shouldn't be returned by read_configuration

[mserranom]

Thanks @darvid7, would you mind posting the steps to reproduce, including the problematic inputs and their outputs vs the expected outputs?

[darvid7]

For sure! this is how I ran into the issue

 dlei@dlei-macbookpro3  ~/Desktop/tmp  git clone https://github.com/overleaf/toolkit.git ./overleaf-toolkit

Cloning into './overleaf-toolkit'...
remote: Enumerating objects: 2343, done.
remote: Counting objects: 100% (950/950), done.
remote: Compressing objects: 100% (204/204), done.
remote: Total 2343 (delta 844), reused 747 (delta 745), pack-reused 1393 (from 3)
Receiving objects: 100% (2343/2343), 863.22 KiB | 5.05 MiB/s, done.
Resolving deltas: 100% (1531/1531), done.
 dlei@dlei-macbookpro3  ~/Desktop/tmp  ls
overleaf-toolkit
 dlei@dlei-macbookpro3  ~/Desktop/tmp  cd overleaf-toolkit 
 dlei@dlei-macbookpro3  ~/Desktop/tmp/overleaf-toolkit   master  ls
bin          CHANGELOG.md config       data         doc          lib          LICENSE      README.md
 ✘ dlei@dlei-macbookpro3  ~/Desktop/tmp/overleaf-toolkit   master  bin/init
Copying config files to 'config/'
 dlei@dlei-macbookpro3  ~/Desktop/tmp/overleaf-toolkit   master  bin/up
---------------------  ERROR  -----------------------
  Invalid MONGO_VERSION: MONGO_VERSION=6.0

  MONGO_VERSION must start with the actual major version of mongo, followed by a dot.
  Example: MONGO_IMAGE=my.dockerhub.com/custom-mongo
           MONGO_VERSION=6.0-custom
---------------------  ERROR  -----------------------
 ✘ dlei@dlei-macbookpro3  ~/Desktop/tmp/overleaf-toolkit   master  

I was following the steps in https://github.com/overleaf/toolkit/blob/master/doc/quick-start-guide.md

With the removal of \1 the bin/up command worked (after creating data dirs)

[aakashkrsingh1]

Definitely works :

[mserranom]

I'm unable to reproduce.

What I'm a bit puzzled about is this log:

Invalid MONGO_VERSION: MONGO_VERSION=6.0

When I set an invalid version in config/overleaf.rc, such as

MONGO_VERSION=invalid-6.0

I only get the actual value of the variable:

Invalid MONGO_VERSION: invalid-6.0

Would you mind sharing the output of bin/doctor? That would help us with the diagnose.

[mserranom]

Looks like it's the same problem reported in #287:

A fix is to install GNU sed (like from homebrew) and modify the script to use gsed instead of sed