Skip to content

fix(fetch) continue event #7480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

fix(fetch) continue event #7480

wants to merge 7 commits into from

Conversation

cirospaciari
Copy link
Member

@cirospaciari cirospaciari commented Dec 6, 2023

What does this PR do?

Fix: #7428

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

Manual tested using s3 and also added a test

@cirospaciari cirospaciari marked this pull request as ready for review December 6, 2023 02:03
Copy link
Contributor

github-actions bot commented Dec 6, 2023

@cirospaciari 5 files with test failures on bun-darwin-aarch64:

  • test/cli/run/env.test.ts
  • test/cli/run/require-cache.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/node/watch/fs.watchFile.test.ts
  • test/js/third_party/postgres/postgres.test.ts

View test output

#e5948e5b3c51aaac6b2b02ae2fce30b20081f2fa

Copy link
Contributor

github-actions bot commented Dec 6, 2023

@cirospaciari 1 files with test failures on linux-x64:

  • test/cli/run/env.test.ts

View test output

#8c7b2d286b109f63f91ac0d7870440b41f9d7c3c

Copy link
Contributor

github-actions bot commented Dec 6, 2023

@cirospaciari 1 files with test failures on linux-x64-baseline:

  • test/cli/run/env.test.ts

View test output

#8c7b2d286b109f63f91ac0d7870440b41f9d7c3c

Copy link
Contributor

github-actions bot commented Dec 6, 2023

@cirospaciari 9 files with test failures on bun-darwin-x64-baseline:

  • test/cli/run/env.test.ts
  • test/js/bun/io/bun-write.test.js
  • test/js/bun/spawn/spawn-streaming-stdout.test.ts
  • test/js/bun/util/which.test.ts
  • test/js/node/fs/fs.test.ts
  • test/js/node/watch/fs.watchFile.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js
  • test/js/web/workers/worker.test.ts

View test output

#8c7b2d286b109f63f91ac0d7870440b41f9d7c3c

Copy link
Contributor

github-actions bot commented Dec 6, 2023

@cirospaciari 11 files with test failures on bun-darwin-x64:

  • test/cli/run/env.test.ts
  • test/js/bun/spawn/spawn-streaming-stdout.test.ts
  • test/js/bun/util/filesink.test.ts
  • test/js/bun/util/which.test.ts
  • test/js/node/fs/fs.test.ts
  • test/js/node/watch/fs.watchFile.test.ts
  • test/js/node/worker_threads/worker_threads.test.ts
  • test/js/third_party/prompts/prompts.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setInterval.test.js
  • test/js/web/timers/setTimeout.test.js

View test output

#8c7b2d286b109f63f91ac0d7870440b41f9d7c3c

@asilvas
Copy link
Contributor

asilvas commented Dec 10, 2023

Was hoping this was going to make 1.0.16 release since this might resolve the AWS SDK client issues. What's the blocker?

@Jarred-Sumner
Copy link
Collaborator

The blocker is that this approach doesn’t actually detect the continue event. It fakes it. It will emit the continue event even when there was no continue sent.

The change needs to be done in the http client to emit a progress event when it receives continue and then propane that through to JS

@cirospaciari
Copy link
Member Author

To resolve this we need duplex streaming on fetch first, so closing in favor of a true solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node 100x faster writing to AWS S3 (PUT's) than Bun v1.0.15 (in same region)
3 participants