-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix(fetch) continue event #7480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ @cirospaciari 5 files with test failures on bun-darwin-aarch64:
|
❌ @cirospaciari 1 files with test failures on linux-x64:
|
❌ @cirospaciari 1 files with test failures on linux-x64-baseline:
|
❌ @cirospaciari 9 files with test failures on bun-darwin-x64-baseline:
|
d91374e
to
1c0b062
Compare
❌ @cirospaciari 11 files with test failures on bun-darwin-x64:
|
1c0b062
to
6188bbe
Compare
Was hoping this was going to make 1.0.16 release since this might resolve the AWS SDK client issues. What's the blocker? |
The blocker is that this approach doesn’t actually detect the continue event. It fakes it. It will emit the continue event even when there was no continue sent. The change needs to be done in the http client to emit a progress event when it receives continue and then propane that through to JS |
To resolve this we need duplex streaming on fetch first, so closing in favor of a true solution. |
What does this PR do?
Fix: #7428
How did you verify your code works?
Manual tested using s3 and also added a test