Skip to content

fix(runtime): exclude unevaluated module in require.cache #5903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2023

Conversation

Hanaasagi
Copy link
Collaborator

What does this PR do?

Close: #5898

#5233 does not filter them in has, which causes that "bufferutil" in require.cache returns true.

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

I wrote automated tests

  • I ran make js and committed the transpiled changes
  • I or my editor ran Prettier on the changed files (or I ran bun fmt)
  • I included a test for the new code, or an existing test covers it

Copy link
Contributor

@paperclover paperclover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wow i forgot about has. good catch.

@Jarred-Sumner Jarred-Sumner merged commit 1445775 into oven-sh:main Sep 23, 2023
@Jarred-Sumner
Copy link
Collaborator

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bufferutil shouldn't be in cache
3 participants