Skip to content

fix(nitro) fix sourcemaps and JSSink closing #5422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 15, 2023
Merged

Conversation

cirospaciari
Copy link
Member

@cirospaciari cirospaciari commented Sep 15, 2023

What does this PR do?

Fix: #5321 and #5107

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

@Jarred-Sumner
Copy link
Collaborator

needs a test

@cirospaciari cirospaciari marked this pull request as ready for review September 15, 2023 01:24
@Jarred-Sumner Jarred-Sumner merged commit da7db22 into main Sep 15, 2023
@Jarred-Sumner Jarred-Sumner deleted the ciro/fix-nitro branch September 15, 2023 06:25
paperclover pushed a commit to SuperAuguste/bun that referenced this pull request Sep 18, 2023
* fix JSSink progress on sourcemap checking

* fix sourcemaps

* update JSSink fix

* undo + tests

---------

Co-authored-by: Jarred Sumner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EXC_BAD_ACCESS under a specific case of ReadableStream
2 participants