Fix bug with multiline string in CRLF terminated files (#4893) #5318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarred-Sumner
approved these changes
Sep 14, 2023
|
Thank you |
|
Thank you for the quick review and merge! |
paperclover
pushed a commit
to SuperAuguste/bun
that referenced
this pull request
Sep 18, 2023
…oven-sh#5318) * Fix bug with multiline string in CRLF terminated files (oven-sh#4893) * add test for oven-sh#4893
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
correctly handles escaped CRLF line endings in multiline strings
fixes #4893
How did you verify your code works?
I manually tested against three files
Pre change it errored on CRLF and passed on the other 2
Post change it passes on all 3
I also added an automated test for the failing CRLF scenario.