Small improvements to `bun test` #3071

Electroid · 2023-05-25T21:29:32Z

Changelog

c09fcb2 The skip icon is now » instead of - (it's nicer).

1d7b76b The title of each test file is now its path instead of its filename.

Before	After

4926e6a When bun test is run in Github Actions, logs are grouped by test file using workflow commands. Detection is done by checking that the GITHUB_ACTIONS environment variable is set to true.

Screen.Recording.2023-05-25.at.3.05.02.PM.online-video-cutter.com.mp4

d1c658e When an error occurs in a test, an annotation is emitted.

Screen.Recording.2023-05-26.at.12.55.01.PM.mov

github-actions · 2023-05-25T22:03:10Z

❌ @Jarred-Sumner 28 files with test failures on linux-x64-baseline:

test/bundler/bun-build-api.test.ts
test/bundler/bundler_browser.test.ts
test/bundler/bundler_compile.test.ts
test/bundler/bundler_edgecase.test.ts
test/bundler/bundler_jsx.test.ts
test/bundler/bundler_naming.test.ts
test/bundler/bundler_plugin.test.ts
test/bundler/esbuild/dce.test.ts
test/bundler/esbuild/default.test.ts
test/bundler/esbuild/extra.test.ts
test/bundler/esbuild/importstar.test.ts
test/bundler/esbuild/loader.test.ts
test/bundler/esbuild/packagejson.test.ts
test/bundler/esbuild/splitting.test.ts
test/bundler/esbuild/ts.test.ts
test/bundler/esbuild/tsconfig.test.ts
test/cli/run/env.test.ts
test/cli/run/preload-test.test.js
test/cli/run/run-cjs.test.ts
test/js/bun/plugin/plugins.test.ts
test/js/bun/resolve/png/test-png-import.test.js
test/js/bun/test/preload-test.test.js
test/js/bun/test/snapshot-tests/snapshots/more-snapshots/different-directory.test.ts
test/js/bun/test/snapshot-tests/snapshots/more.test.ts
test/js/bun/websocket/websocket-server.test.ts
test/js/node/child_process/child_process-node.test.js
test/js/node/dns/node-dns.test.js
test/transpiler/transpiler.test.js

View test output

^{#ea31bf4cbbfee3897e9c26099d3de23a76aa5947}

github-actions · 2023-05-25T22:06:44Z

❌ @Jarred-Sumner 28 files with test failures on linux-x64:

test/bundler/bun-build-api.test.ts
test/bundler/bundler_browser.test.ts
test/bundler/bundler_compile.test.ts
test/bundler/bundler_edgecase.test.ts
test/bundler/bundler_jsx.test.ts
test/bundler/bundler_naming.test.ts
test/bundler/bundler_plugin.test.ts
test/bundler/esbuild/dce.test.ts
test/bundler/esbuild/default.test.ts
test/bundler/esbuild/extra.test.ts
test/bundler/esbuild/importstar.test.ts
test/bundler/esbuild/loader.test.ts
test/bundler/esbuild/packagejson.test.ts
test/bundler/esbuild/splitting.test.ts
test/bundler/esbuild/ts.test.ts
test/bundler/esbuild/tsconfig.test.ts
test/cli/run/env.test.ts
test/cli/run/preload-test.test.js
test/cli/run/run-cjs.test.ts
test/js/bun/plugin/plugins.test.ts
test/js/bun/resolve/png/test-png-import.test.js
test/js/bun/test/preload-test.test.js
test/js/bun/test/snapshot-tests/snapshots/more-snapshots/different-directory.test.ts
test/js/bun/test/snapshot-tests/snapshots/more.test.ts
test/js/bun/websocket/websocket-server.test.ts
test/js/node/child_process/child_process-node.test.js
test/js/node/dns/node-dns.test.js
test/transpiler/transpiler.test.js

View test output

^{#ea31bf4cbbfee3897e9c26099d3de23a76aa5947}

github-actions · 2023-05-25T22:10:04Z

❌ @Jarred-Sumner 31 files with test failures on bun-darwin-x64-baseline:

test/bundler/bun-build-api.test.ts
test/bundler/bundler_browser.test.ts
test/bundler/bundler_compile.test.ts
test/bundler/bundler_edgecase.test.ts
test/bundler/bundler_jsx.test.ts
test/bundler/bundler_naming.test.ts
test/bundler/bundler_plugin.test.ts
test/bundler/esbuild/dce.test.ts
test/bundler/esbuild/default.test.ts
test/bundler/esbuild/extra.test.ts
test/bundler/esbuild/importstar.test.ts
test/bundler/esbuild/loader.test.ts
test/bundler/esbuild/packagejson.test.ts
test/bundler/esbuild/splitting.test.ts
test/bundler/esbuild/ts.test.ts
test/bundler/esbuild/tsconfig.test.ts
test/cli/run/env.test.ts
test/cli/run/preload-test.test.js
test/cli/run/run-cjs.test.ts
test/js/bun/plugin/plugins.test.ts
test/js/bun/resolve/png/test-png-import.test.js
test/js/bun/spawn/spawn-streaming-stdin.test.ts
test/js/bun/sqlite/sqlite.test.js
test/js/bun/test/preload-test.test.js
test/js/bun/test/snapshot-tests/snapshots/more-snapshots/different-directory.test.ts
test/js/bun/test/snapshot-tests/snapshots/more.test.ts
test/js/bun/util/sleepSync.test.ts
test/js/node/child_process/child_process-node.test.js
test/js/node/dns/node-dns.test.js
test/js/web/timers/setTimeout.test.js
test/transpiler/transpiler.test.js

View test output

^{#ea31bf4cbbfee3897e9c26099d3de23a76aa5947}

src/output.zig

github-actions · 2023-05-26T19:11:11Z

✅ prettier errors have been resolved. Thank you.

^{#ea31bf4cbbfee3897e9c26099d3de23a76aa5947}

Jarred-Sumner · 2023-05-26T23:09:35Z

This looks good though there are new test failures

Jarred-Sumner · 2023-05-28T20:22:43Z

test.runIf

interesting

Jarred-Sumner · 2023-05-28T20:23:02Z

maybe test.if?

simylein · 2023-05-30T15:47:08Z

If you are already on it can we implement that test failures log last because the constant scrolling up the logs to find details about failing tests is rather annoying. I remember having seen an issue about this but cannot find it at the moment.

https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#grouping-log-lines

https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-error-message

… is already ANSI

By default, `test.todo()` is no longer run, unless `--run-todo` is specified.

* toBeNil() * toBeBoolean() * toBeTrue() * toBeFalse() * toBeNumber() * toBeInteger() * toBeFinite() * toBePositive() * toBeNegative() * toBeWithin() * toBeSymbol() * toBeFunction() * toBeDate() * toBeString() * toInclude() * toStartWith() * toEndWith()

Electroid added enhancement New feature or request bun:test Something related to the `bun test` runner labels May 25, 2023

Electroid requested a review from Jarred-Sumner May 25, 2023 21:29

Jarred-Sumner reviewed May 26, 2023

View reviewed changes

src/output.zig Outdated Show resolved Hide resolved

Electroid requested a review from Jarred-Sumner May 26, 2023 19:58

Electroid force-pushed the feat/bun-test-ci branch from 209160b to 1a65706 Compare May 26, 2023 23:01

Electroid added 16 commits May 30, 2023 16:21

Change status icon for skipped tests from "-" to "»"

2379551

Show file path instead of filename in bun test

46865d7

Emit collapsable logs when running bun test in Github Actions

743d5d1

https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#grouping-log-lines

Add fallback for test icons when emojis are not available

22e8bb1

Only check for GITHUB_ACTIONS when running bun test

4b28c9c

Emit error annotations when running bun test in Github Actions

cf04522

https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-error-message

Remove ANSI output from Github annotation, it doesn't work

33c4c2e

Remove outdated code from internal test runner

c373812

Add GithubActionFormatter to handle cases where error name or message…

4c64619

… is already ANSI

Fix formatting of test

c253de8

Fix #3070

c22563f

Implement bun test --run-todo

f84ce25

By default, `test.todo()` is no longer run, unless `--run-todo` is specified.

Fix test that relies on test.todo() being run

e0b2366

Support vitest-style test options

865c77d

Disable GITHUB_ACTION in test harness

af5ebb0

Add types for TestOptions

78637da

Electroid added 7 commits May 30, 2023 16:21

Fix bug where test.skip() actually ran

f76b990

Implement test.skipIf() and describe.skipIf()

db51eb7

Implement test.runIf()

469aa46

Move DiffFormatter to its own file

74e55d3

Fix bug where Bun.inspect() would emit a Github annotation

14584a5

Introduce bun test --only, rename --run-todo to --todo

0f0dde6

Implement test.if(), describe.if(), and other test fixes

f353bc5

Electroid force-pushed the feat/bun-test-ci branch from 8194585 to f353bc5 Compare May 30, 2023 23:21

Electroid and others added 14 commits May 30, 2023 16:24

Remove unwanted files from last commit

a6547b9

Fix last reference to --run-todo

6bcf9aa

Fix memory issues with printing github actions text

24bb766

Update bindings.zig

e9efc59

Fix bug with test.only()

23bbaa1

Remove debug test

40c7833

Make the github annotations better

aaa62bf

Improve .vscode/launch.json

08d8763

Implement expect().toBeNil()

05de71d

Remove .only() from test

93dd932

Implement toBeBoolean(), toBeTrue(), toBeFalse()

3cff7c5

Add lots of matchers

cc16ac2

* toBeNil() * toBeBoolean() * toBeTrue() * toBeFalse() * toBeNumber() * toBeInteger() * toBeFinite() * toBePositive() * toBeNegative() * toBeWithin() * toBeSymbol() * toBeFunction() * toBeDate() * toBeString() * toInclude() * toStartWith() * toEndWith()

Fix #3135

878b90c

Reduce verbosity of test

94c188e

Electroid mentioned this pull request May 31, 2023

expect().toHaveProperty() throw segfault if expect value is undefined #3135

Closed

This was linked to issues May 31, 2023

expect().toHaveProperty() throw segfault if expect value is undefined #3135

Closed

bun test <filter> should check against relative paths #3070

Closed

Electroid force-pushed the feat/bun-test-ci branch from ccfd49a to 94c188e Compare June 1, 2023 02:25

Fix snapshot bug

363c562

Jarred-Sumner merged commit e632941 into main Jun 1, 2023

Jarred-Sumner deleted the feat/bun-test-ci branch June 1, 2023 06:12

hi-ogawa mentioned this pull request Feb 6, 2024

feat(vitest): add github actions reporter vitest-dev/vitest#5093

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Small improvements to `bun test` #3071

Small improvements to `bun test` #3071

Uh oh!

Electroid commented May 25, 2023 •

edited

Loading

Uh oh!

github-actions bot commented May 25, 2023 •

edited

Loading

Uh oh!

github-actions bot commented May 25, 2023 •

edited

Loading

Uh oh!

github-actions bot commented May 25, 2023 •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented May 26, 2023 •

edited

Loading

Uh oh!

Jarred-Sumner commented May 26, 2023

Uh oh!

Jarred-Sumner commented May 28, 2023

Uh oh!

Jarred-Sumner commented May 28, 2023

Uh oh!

simylein commented May 30, 2023

Uh oh!

Uh oh!

Small improvements to bun test #3071

Small improvements to bun test #3071

Uh oh!

Conversation

Electroid commented May 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Uh oh!

github-actions bot commented May 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented May 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jarred-Sumner commented May 26, 2023

Uh oh!

Jarred-Sumner commented May 28, 2023

Uh oh!

Jarred-Sumner commented May 28, 2023

Uh oh!

simylein commented May 30, 2023

Uh oh!

Uh oh!

Small improvements to `bun test` #3071

Small improvements to `bun test` #3071

Electroid commented May 25, 2023 •

edited

Loading

github-actions bot commented May 25, 2023 •

edited

Loading

github-actions bot commented May 25, 2023 •

edited

Loading

github-actions bot commented May 25, 2023 •

edited

Loading

github-actions bot commented May 26, 2023 •

edited

Loading