-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Correct the typo algorithme to algorithm #19572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Correct the typo algorithme to algorithm #19572
Conversation
98ed44c
to
38177a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM can you add a test in test/js/bun/s3/s3.test.ts
?
903a64f
to
3f0baaa
Compare
@cirospaciari Could you please check it again? |
If you take a look in allCredentials we have R2 and Minio you can add a test only for R2 that supports |
3f0baaa
to
16397c0
Compare
Thank you for the advice. Therefore, I wasn't able to add a test for it. |
4a81142
to
90e626a
Compare
90e626a
to
26649eb
Compare
What does this PR do?
How did you verify your code works?
I have fixed the issue described in this issue.
I confirmed that the build succeeds by running
bun run build