Skip to content

Correct the typo algorithme to algorithm #19572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

staakaar
Copy link

What does this PR do?

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

I have fixed the issue described in this issue.

I confirmed that the build succeeds by running bun run build

@staakaar staakaar force-pushed the typo-s3-response-checksum-algorithm branch from 98ed44c to 38177a6 Compare May 10, 2025 15:33
Copy link
Member

@cirospaciari cirospaciari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM can you add a test in test/js/bun/s3/s3.test.ts?

@staakaar staakaar force-pushed the typo-s3-response-checksum-algorithm branch from 903a64f to 3f0baaa Compare May 15, 2025 14:03
@staakaar
Copy link
Author

@cirospaciari
Thank you for your review and feedback.
I have added test to the s3-test.ts file.
However, MinIO does not support checksumAlgorithm.

Could you please check it again?

@staakaar staakaar requested a review from cirospaciari May 15, 2025 16:05
@cirospaciari
Copy link
Member

checksumAlgorithm

If you take a look in allCredentials we have R2 and Minio you can add a test only for R2 that supports checksumAlgorithm and skip minio

@staakaar staakaar force-pushed the typo-s3-response-checksum-algorithm branch from 3f0baaa to 16397c0 Compare May 16, 2025 15:32
@staakaar
Copy link
Author

@cirospaciari

Thank you for the advice.
I wasn't able to retrieve the value of the checksumAlgorithm property in R2.
I suspect that R2 doesn't support it .

Therefore, I wasn't able to add a test for it.

@staakaar staakaar requested a review from cirospaciari May 16, 2025 15:37
@staakaar staakaar force-pushed the typo-s3-response-checksum-algorithm branch 3 times, most recently from 4a81142 to 90e626a Compare May 20, 2025 12:51
@staakaar staakaar force-pushed the typo-s3-response-checksum-algorithm branch from 90e626a to 26649eb Compare May 22, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants