Skip to content

feat(s3Client): add support for ListObjectsV2 action #16948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
Apr 2, 2025

Conversation

Inqnuam
Copy link
Contributor

@Inqnuam Inqnuam commented Jan 31, 2025

What does this PR do?

This PR adds support for S3 ListObjectsV2 action.
Same input/output as @aws-sdk/s3-client.

Closes #16495
May be helpful for #8947

  • Documentation or TypeScript types
  • Code changes

How did you verify your code works?

I wrote automated tests

  • I included a test for the new code, or existing tests cover it
  • I ran my tests locally and they pass (bun-debug test test/js/bun/s3/s3-list-objects.test.ts)
  • I ran my tests on AWS and they pass

If Zig files changed:

  • I checked the lifetime of memory allocated to verify it's (1) freed and (2) only freed when it should be
  • I included a test for the new code, or an existing test covers it
  • JSValue used outside outside of the stack is either wrapped in a JSC.Strong or is JSValueProtect'ed
  • I wrote TypeScript/JavaScript tests and they pass locally (bun-debug test test/js/bun/s3/s3-list-objects.test.ts)

If new methods, getters, or setters were added to a publicly exposed class:

  • I added TypeScript types for the new methods, getters, or setters

@zshzebra
Copy link

zshzebra commented Feb 2, 2025

Hopefully a maintainer can get to this soon. I would love to see this added.

@Inqnuam Inqnuam requested a review from cirospaciari February 19, 2025 22:23
@Inqnuam Inqnuam requested a review from cirospaciari February 20, 2025 01:08
@geoffhendrey
Copy link

We are trying to work around problems with listObjectsV2 hanging on bun when there are large numbers of objects in the bucket. WOuld love to see this merge

@rileymiller
Copy link

Agreed, we are also blocked from adopting bun for some s3 workloads we'd love to migrate over until this is merged.

@cirospaciari cirospaciari merged commit 946f41c into oven-sh:main Apr 2, 2025
71 checks passed
@cirospaciari
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

s3 list function
5 participants