-
Notifications
You must be signed in to change notification settings - Fork 3.1k
feat(s3Client): add support for ListObjectsV2 action #16948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully a maintainer can get to this soon. I would love to see this added. |
cirospaciari
requested changes
Feb 7, 2025
cirospaciari
requested changes
Feb 19, 2025
We are trying to work around problems with listObjectsV2 hanging on bun when there are large numbers of objects in the bucket. WOuld love to see this merge |
Agreed, we are also blocked from adopting bun for some s3 workloads we'd love to migrate over until this is merged. |
cirospaciari
approved these changes
Apr 2, 2025
Thank you! |
paperclover
pushed a commit
that referenced
this pull request
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for S3 ListObjectsV2 action.
Same input/output as
@aws-sdk/s3-client
.Closes #16495
May be helpful for #8947
How did you verify your code works?
I wrote automated tests
bun-debug test test/js/bun/s3/s3-list-objects.test.ts
)If Zig files changed:
bun-debug test test/js/bun/s3/s3-list-objects.test.ts
)If new methods, getters, or setters were added to a publicly exposed class: