Attempt to fix unresolved terminate() promise #11376
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Worker.terminate() on JS-side expects "close" event to happen in order to complete promise, but this event will never happen, if worker is already terminated. The "solution" is to pass "already exited" flag to JS-side, so it can resolve the promise without any events.
More work is still required - there's some hacks to allow
boolean
to pass through incompatible Worker APIThis PR may fix #11335 and #9998
How did you verify your code works?
None of the automated tests are provided, but the issues are now fixed and there are no big changes - just passing
bool
around