Support V8 C++ APIs for "nan" addons and other packages to work

[xhyrom]

Affected packages

• better-sqlite3
• node-canvas@v2 (node-canvas v3 is supported)
• midi
• libxmljs
• bignum
• zeromq
• node-libcurl
• bson-ext
• heapdump
• @datadog/native-metrics
• tiny-secp256k1
• tree-sitter-c-sharp
• chacha-native
• @sentry/profiling-node
• pdfjs-dist
• gl
• leveldown / pouchdb
• sleep
• cpu-features
• odbc
• msgpackr
• re2
• node-pty
• i2c
• gdal-async
• dd-trace
• blake2

Functions implemented

• v8::Isolate::GetCurrent()
• v8::Isolate::TryGetCurrent()
• v8::Isolate::GetCurrentContext()
• v8::Number::New(v8::Isolate*, double)
• v8::Number::Value() const
• v8::String::NewFromUtf8(v8::Isolate*, char const*, v8::NewStringType, int)
• v8::String::WriteUtf8(v8::Isolate*, char*, int, int*, int) const
• v8::api_internal::ToLocalEmpty()
• v8::String::Length() const
• v8::External::New(v8::Isolate*, void*)
• v8::External::Value() const
• v8::Object::New(v8::Isolate*)
• v8::Object::Set(v8::Local<v8::Context>, v8::Local<v8::Value>, v8::Local<v8::Value>)
• v8::Object::SetInternalField(int, v8::Local<v8::Data>)
• v8::Object::SlowGetInternalField(int)
• v8::HandleScope::HandleScope(v8::Isolate*)
• v8::HandleScope::~HandleScope()
• v8::FunctionTemplate::GetFunction(v8::Local<v8::Context>)
• v8::FunctionTemplate::New(v8::Isolate*, void (*)(v8::FunctionCallbackInfo<v8::Value> const&), v8::Local<v8::Value>, v8::Local<v8::Signature>, int, v8::ConstructorBehavior, v8::SideEffectType, v8::CFunction const*, unsigned short, unsigned short, unsigned short) (only when all parameters past data are their default values)
• v8::ObjectTemplate::NewInstance(v8::Local<v8::Context>)
• v8::ObjectTemplate::SetInternalFieldCount(int)
• v8::ObjectTemplate::InternalFieldCount() const
• v8::ObjectTemplate::New(v8::Isolate*, v8::Local<v8::FunctionTemplate>) (only when no FunctionTemplate is provided)
• v8::EscapableHandleScopeBase::EscapeSlot(unsigned long*)
• v8::EscapableHandleScopeBase::EscapableHandleScopeBase(v8::Isolate*)
• node_module_register
• v8::Function::SetName(v8::Local<v8::String>)
• v8::Value::IsBoolean() const
• v8::Boolean::Value() const
• v8::Value::FullIsTrue() const
• v8::Value::FullIsFalse() const
• v8::EscapableHandleScope::EscapableHandleScope(v8::Isolate*)
• v8::EscapableHandleScope::~EscapableHandleScope()
• v8::Value::IsObject() const
• v8::Value::IsNumber() const
• v8::Value::IsUint32() const
• v8::Value::Uint32Value(v8::Local<v8::Context>) const
• v8::Value::IsUndefined() const
• v8::Value::IsNull() const
• v8::Value::IsNullOrUndefined() const
• v8::Value::IsTrue() const
• v8::Value::IsFalse() const
• v8::Value::IsString() const
• v8::Boolean::New(v8::Isolate*, bool)
• v8::Object::GetInternalField(int)
• node::AddEnvironmentCleanupHook(v8::Isolate*, void (*)(void*), void*)
• node::RemoveEnvironmentCleanupHook(v8::Isolate*, void (*)(void*), void*)
• v8::HandleScope::CreateHandle(v8::internal::Isolate*, unsigned long)
• v8::internal::IsolateFromNeverReadOnlySpaceObject(unsigned long)
• v8::Array::New(v8::Isolate*, v8::Local<v8::Value>*, unsigned long)
• v8::Object::Get(v8::Local<v8::Context>, v8::Local<v8::Value>)

Major areas of unimplemented functionality

• Array
• ObjectTemplate with a constructor function
• Less-simple cases of FunctionTemplate
• ArrayBuffer
• bun install fixes (need to pass node-gyp the right version)
• Doubles
• UTF-16 strings
• Persistent handles

What version of Bun is running?

0.8.0+ad326b77342dd3d8585a30b7da803d32f9c11fe2

What platform is your computer?

Linux 6.4.10-artix1-1 x86_64 unknown

What steps can reproduce the bug?

import Database from 'better-sqlite3';
const db = new Database('foobar.db', {});

console.log(db.prepare("CREATE TABLE TEST").run());

What is the expected behavior?

Run as normally

What do you see instead?

/usr/bin/bun: symbol lookup error: /home/hyro/Workspace/booo/node_modules/better-sqlite3/build/Release/better_sqlite3.node: undefined symbol: node_module_register

Additional information

Related thread: 1144181146809270332
Message: https://discord.com/channels/876711213126520882/1144181146809270332/1144184224006557747

All versions are affected

[floydjones1]

This also happens for node-libcurl

[issadarkthing]

I also encounter this error

[Zykatious]

this also happens for bson-ext

[autoscatto]

also for heapdump

[vroudge]

same for @datadog/native-metrics

[uditdc]

Likewise for tiny-secp256k1

[ozyman42]

Also for cdktf-cli #5306

[obedm503]

Also happens with tree-sitter-c-sharp

[Scitz0]

Same error for chacha-native

[metawrap-dev]

same for node-canvas

[4i8]

bun: symbol lookup error: /root/rut/node_modules/canvas/build/Release/canvas.node: undefined symbol: node_module_register
same for canvas

[edi9999]

Same for libxmljs

[floydjones1]

How can we get a little more attention to this. This is holding me back from using bun in production. 😢
node-libcurl

bun: symbol lookup error: /home/.../node_modules/node-libcurl/lib/binding/node_libcurl.node: undefined symbol: node_module_register

[M-Gonzalo]

bun: symbol lookup error: /root/rut/node_modules/canvas/build/Release/canvas.node: undefined symbol: node_module_register same for canvas

me too

[frani]

similar error:

bun: symbol lookup error: /usr/src/app/node_modules/@sentry/profiling-node/lib/sentry_cpu_profiler-linux-x64-glibc-115.node: undefined symbol: _ZN2v87Isolate10GetCurrentEv

[xbura1han]

Also happening for Sentry & bcrypt
Sentry code:
Code:

const Sentry = require('@sentry/bun');
const { ProfilingIntegration } = require("@sentry/profiling-node")

Error:

bun: symbol lookup error: /root/projects/userBackend/node_modules/@sentry/profiling-node/lib/sentry_cpu_profiler-linux-x64-glibc-115.node: undefined symbol: _ZN2v87Isolate10GetCurrentEv

[ashkalor]

Hey guys wanted to ask if there is any update on this issue? Is this planned for the immediate roadmap? Feels like the only missing piece for us to completely migrate from NodeJS.

[190n]

It's on our roadmap but we're not actively working on this at the moment. Right now our main focus with Node compatibility is improving support for their builtin packages.

[devlzcode]

Its unfortunate that I'm forced to use node to run testcontainers since they still don't work in Bun

[jlucaso1]

Along with the report of @Yash-Singh1 #5578 (comment)
An bug has found when try to access napi_register_module_v1 inside a worker thread.
I think this can be a item in todo.

[190n]

@jlucaso1 thanks for reporting, but that's not related to the V8 C++ API. Could you open a new issue?

[spiffytech]

This may also be an issue for node-talib.