fs.writeFile mode is not Node.js compatible

[gutenye]

What version of Bun is running?

0.6.14

What platform is your computer?

No response

What steps can reproduce the bug?

import fs from 'fs'
fs.writeFileSync('a.txt', 'content', { mode: 33188 })

What is the expected behavior?

Works fine on Node

What do you see instead?

TypeError: Invalid mode: must be an octal number
code: "ERR_INVALID_ARG_TYPE"

Additional information

[Hanaasagi]

It looks like the upper limit of the value is constrained to 0o777 in bun, which is causing this issue.

bun/src/bun.js/node/types.zig

Lines 1008 to 1011 in 636cec0

	if (mode_int < 0 or mode_int > 0o777) {
	JSC.throwInvalidArguments("Invalid mode: must be an octal number", .{}, ctx, exception);
	return null;
	}

In Node.js, this limit is a u32.

https://github.com/nodejs/node/blob/9dd574c9e232515aa894795b8a2522f53024b6f7/lib/internal/validators.js#L69-L80

[Jarred-Sumner]

ah, we probably should wrap it