🐛 fix/helm: refactor values, fix validation webhook, rbac #430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfbus
force-pushed
the
fix/helm_validation
branch
from
55e0f73 to
66ed30f
Compare
jfbus
changed the title
jfbus
force-pushed
the
fix/helm_validation
branch
from
66ed30f to
f010ebd
Compare
jfbus
force-pushed
the
fix/helm_validation
branch
from
f010ebd to
a625609
Compare
jfbus
changed the title
outscale-toa
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To follow Helm best practices, flatten values tree & use camelCase.
A validation webhook did not point to the right service and some rbac rules were missing.