sysroot: Detect early on when /boot is on vfat #3405
+51
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do want to support this (as part of supporing the Boot Loader Spec) but because we use symlinks in `/boot`, can't yet. Error out very early on consistently if we detect vfat for /boot, but also add a member variable to keep track of this in preparation for supporting it.
|
cc @igoropaniuk - can you review this? |
There was a problem hiding this comment.
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- tests/kolainst/nondestructive/itest-alt-sysroot.sh: Language not supported
Comments suppressed due to low confidence (1)
src/libostree/ostree-sysroot.c:352
- The error message from glnx_throw_errno_prefix is simply "fstatfs"; consider adding more contextual information (e.g. noting the failure occurred while checking the boot partition) to make debugging easier.
if (fstatfs (self->boot_fd, &stbuf) < 0)
Comment on lines
+2221
to
2222
| g_assert (!sysroot->boot_is_vfat); | ||
|
|
There was a problem hiding this comment.
Using g_assert to enforce that boot_is_vfat is false may not be sufficient for production, as asserts can be disabled. Consider replacing the assertion with explicit error handling to ensure consistent behavior in all builds.
Suggested change
| g_assert (!sysroot->boot_is_vfat); | |
| if (sysroot->boot_is_vfat) | |
| return glnx_throw (error, "boot_is_vfat must be false"); |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do want to support this (as part of supporing the Boot Loader Spec) but because we use symlinks in
/boot, can't yet.Error out very early on consistently if we detect
vfat for /boot, but also add a member variable to keep track of this in preparation for supporting it.