Skip to content

Renamed some framework IDs (non-functional) #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

eddie-knight
Copy link
Contributor

@eddie-knight eddie-knight commented Jul 8, 2025

This is related to, but not dependent on or blocking #349

I noticed that some of the framework names could have clearer IDs, and since we aren't restricted by length, I've proposed:

  • ScCrd -> Scorecard
  • OCRE -> OpenCRE
  • OC -> ISO-18974

For review simplicity, I'd like to do this prior to migrating to the full use of metadata.yaml in a subsequent PR

funnelfiasco
funnelfiasco previously approved these changes Jul 8, 2025
Copy link
Contributor

@funnelfiasco funnelfiasco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good change to me. We could call 18974 iso18974 if that feels a little clearer, but I'm fine either way.

I built it in my fork and everything worked as expected.

@eddie-knight eddie-knight enabled auto-merge (squash) July 9, 2025 00:24
Copy link
Contributor

@trumant trumant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find ISO-18974 provides more clarity than simply 18974. The remaining changes definitely add clarity though.

Signed-off-by: Eddie Knight <[email protected]>
SecurityCRob
SecurityCRob previously approved these changes Jul 11, 2025
@funnelfiasco
Copy link
Contributor

Whoops! Fixing a conflict invalidated previous reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants