Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module name in go.mod #91

Merged
merged 2 commits into from
Jun 7, 2021
Merged

Conversation

zwass
Copy link
Member

@zwass zwass commented Jun 6, 2021

Prior to this change and since the move from kolide/osquery-go to
osquery/osquery-go, attempting to use this package could result in an
error such as:

go: downloading github.com/osquery/osquery-go v0.0.0-20200604192029-b019be7063ac
go get: github.com/osquery/osquery-go@none updating to
github.com/osquery/[email protected]: parsing go.mod:
module declares its path as: github.com/kolide/osquery-go
but was required as: github.com/osquery/osquery-go

Prior to this change and since the move from kolide/osquery-go to
osquery/osquery-go, attempting to use this package could result in an
error such as:

go: downloading github.com/osquery/osquery-go v0.0.0-20200604192029-b019be7063ac
go get: github.com/osquery/osquery-go@none updating to
	github.com/osquery/[email protected]: parsing go.mod:
	module declares its path as: github.com/kolide/osquery-go
	        but was required as: github.com/osquery/osquery-go
Copy link
Member

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. Can we ditch the go modules?

Copy link
Member

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try! We can always fail forward

@directionless directionless merged commit df1df42 into osquery:master Jun 7, 2021
@zwass zwass deleted the fix-package-name branch June 14, 2021 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants