Skip to content

Matching progress probably does not match actual process #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
osmanovv opened this issue Aug 1, 2020 · 1 comment · Fixed by #20
Closed

Matching progress probably does not match actual process #17

osmanovv opened this issue Aug 1, 2020 · 1 comment · Fixed by #20
Assignees
@osmanovv
Labels
bug Something isn't working

Comments

@osmanovv
Copy link
Owner

osmanovv commented Aug 1, 2020

Progress ends earlier than actual matching task. Check progress maximum value for matching step.
@osmanovv osmanovv added the bug Something isn't working label Aug 1, 2020
@osmanovv osmanovv self-assigned this Aug 1, 2020
@osmanovv osmanovv added WIP Work in progress and removed WIP Work in progress labels Aug 1, 2020
@osmanovv osmanovv linked a pull request Aug 1, 2020 that will close this issue
fix #17 - synching progress is more accurate now #20
Merged
@osmanovv
Copy link
Owner Author

osmanovv commented Aug 1, 2020

Yes, this was a bug. Since synchronization takes into account that files may not completely overlap, use the maximum possible length of both files. Before that, matching was only by the length of the main audio recording.

@osmanovv osmanovv closed this as completed Aug 1, 2020
osmanovv added a commit that referenced this issue Aug 9, 2020
@osmanovv
v0.8.1.115 release
0d4d8ef 
v0.8.1.115
- [x] Improved usability (#6)
- [x] Added ability to export synchronized file with `FFmpeg` (#7)
- [x] Fixed multiple instances run (#11)
- [x] Fixed progress display (while matching files) (#17)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@osmanovv osmanovv

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #17 - synching progress is more accurate now osmanovv/auxmic
1 participant
@osmanovv