Skip to content

chore: remove .only from test #2893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2022
Merged

chore: remove .only from test #2893

merged 1 commit into from
Nov 15, 2022

Conversation

jonas-jonas
Copy link
Member

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@zepatrik
Copy link
Member

Cypress is so stupid, they don't even have a way to fail on only 🤦
cypress-io/cypress#239
Really looking forward to when the e2e tests here are rewritten in playwright...

@zepatrik zepatrik merged commit b3dca56 into master Nov 15, 2022
@zepatrik zepatrik deleted the fix/removeOnly branch November 15, 2022 14:33
@jonas-jonas
Copy link
Member Author

@zepatrik yep, was already looking into husky and pre-push git hooks. :D Maybe we could also run https://github.com/bahmutov/stop-only as an action.

peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants